From: Jonathan Nieder <jrnieder@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Huacai Chen <chenhc@lemote.com>,
Charles Wang <muming.wq@taobao.com>,
Ingo Molnar <mingo@kernel.org>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Seems like "sched: Add missing call to calc_load_exit_idle()" should be reverted in 3.5 branch
Date: Fri, 5 Oct 2012 10:10:07 -0700 [thread overview]
Message-ID: <20121005171007.GC15867@elie.Belkin> (raw)
In-Reply-To: <1349432466.14388.25.camel@twins>
Peter Zijlstra wrote:
> On Thu, 2012-10-04 at 15:27 -0700, Greg Kroah-Hartman wrote:
>> I'm puzzled as well. Any ideas if I should do anything here or not?
>
> So I think the current v3.5.5 code is fine.
Now I'm puzzled. You wrote:
| However, since we don't restart the tick, we won't be sampling load muck
| and calling calc_load_exit_idle() from there is bound to confuse state.
Doesn't that mean 900404e5d201 "sched: Add missing call to
calc_load_exit_idle()" which is part of 3.5.5 was problematic? Or
did I just miscount the number of "not"s?
next prev parent reply other threads:[~2012-10-05 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAhV-H54CJdg+UekpucZ=kOgCY5r5vvYQ+v4VwAMTCv+mCedXA@mail.gmail.com>
2012-10-04 17:46 ` Seems like "sched: Add missing call to calc_load_exit_idle()" should be reverted in 3.5 branch Greg Kroah-Hartman
2012-10-04 18:31 ` Peter Zijlstra
2012-10-04 22:27 ` Greg Kroah-Hartman
2012-10-05 10:21 ` Peter Zijlstra
2012-10-05 16:17 ` Greg Kroah-Hartman
2012-10-05 17:10 ` Jonathan Nieder [this message]
2012-10-05 17:23 ` Peter Zijlstra
2012-10-08 11:33 ` Charles Wang
2012-10-05 1:39 ` Jonathan Nieder
2012-10-08 11:23 ` Charles Wang
2012-10-05 0:35 陈华才
-- strict thread matches above, loose matches on Subject: below --
2012-10-13 3:39 陈华才
2012-10-13 6:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005171007.GC15867@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=chenhc@lemote.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=muming.wq@taobao.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).