From: Arnd Bergmann <arnd@arndb.de>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: akpm@linux-foundation.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
festevam@gmail.com
Subject: Re: [PATCH] sysctl: Fix 'defined but not used' warning
Date: Fri, 5 Oct 2012 18:03:28 +0000 [thread overview]
Message-ID: <201210051803.28848.arnd@arndb.de> (raw)
In-Reply-To: <1349452668-8601-1-git-send-email-fabio.estevam@freescale.com>
On Friday 05 October 2012, Fabio Estevam wrote:
> Since commit 4ae834f767(sched/numa: Implement NUMA home-node selection code)
> building a kernel with CONFIG_SMP disabled causes the following warning:
>
> kernel/sysctl.c:259:12: warning: 'min_sched_tunable_scaling' defined but not used [-Wunused-variable]
> kernel/sysctl.c:260:12: warning: 'max_sched_tunable_scaling' defined but not used [-Wunused-variable]
>
> Annotate theses variables as '__maybe_unused'.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
I noticed the same thing and had a different fix for it, but yours is better anyway.
prev parent reply other threads:[~2012-10-05 20:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 15:57 [PATCH] sysctl: Fix 'defined but not used' warning Fabio Estevam
2012-10-05 18:03 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210051803.28848.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox