From: Thorsten Kranzkowski <dl8bcu@dl8bcu.de>
To: Oleg Nesterov <oleg@redhat.com>
Cc: peterz@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [regression] boot failure on alpha, bisected
Date: Sun, 7 Oct 2012 19:41:47 +0000 [thread overview]
Message-ID: <20121007194147.GA931@ds20.borg.net> (raw)
In-Reply-To: <20121007191627.GA19278@redhat.com>
On Sun, Oct 07, 2012 at 09:16:27PM +0200, Oleg Nesterov wrote:
> On 10/07, Thorsten Kranzkowski wrote:
> > On Sun, Oct 07, 2012 at 07:13:00PM +0200, Oleg Nesterov wrote:
> > > On 10/07, Oleg Nesterov wrote:
> > > >
> > > > Hmm. I know nothing about arch/alpha and I can't understand its entry.S.
> > > > But _it seems_ to me that do_notify_resume() is called with irqs disabled.
> > > > If this is true, then imho arch/alpha should be fixed.
> > > >
> > > > Before this commit task_work_run() enabled irqs, but this was the "side
> > > > effect" of spin_lock_irq/spin_unlock_irq, we should not rely on this.
> > >
> > > Could you please test the debugging patch below?
> >
> > Of course. With that patch applied the kernel (ac3d0da) boots again. The trace line
> > is printed about once a second, with values '2' and '4'.
>
> Thanks a lot Thorsten!
>
> So I'll probably send the patch which enables interrupts in
> task_work_run(). I guess this needs "if (irqs_disabled())"
> for lockdep.
>
> The question is, should I add the warning to remind that this
> arch needs a fix?
If you do, then please warn only once, otherwise there will be a lot of
warnings :-)
Thorsten
--
| Thorsten Kranzkowski Internet: dl8bcu@dl8bcu.de |
| Mobile: ++49 170 1876134 Snail: Kiebitzstr. 14, 49324 Melle, Germany |
| Ampr: dl8bcu@db0lj.#rpl.deu.eu, dl8bcu@marvin.dl8bcu.ampr.org [44.130.8.19] |
next prev parent reply other threads:[~2012-10-07 19:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-06 20:47 [regression] boot failure on alpha, bisected Thorsten Kranzkowski
2012-10-07 16:55 ` Oleg Nesterov
2012-10-07 17:08 ` Al Viro
2012-10-07 17:33 ` Oleg Nesterov
2012-10-07 19:39 ` Al Viro
2012-10-08 14:14 ` Dialup Jon Norstog
2012-10-08 14:14 ` Dialup Jon Norstog
2012-10-08 18:59 ` Oleg Nesterov
2012-10-07 17:13 ` Oleg Nesterov
2012-10-07 18:04 ` Thorsten Kranzkowski
2012-10-07 19:16 ` Oleg Nesterov
2012-10-07 19:41 ` Thorsten Kranzkowski [this message]
2012-10-08 18:59 ` Geert Uytterhoeven
2012-10-08 19:10 ` Oleg Nesterov
2012-10-12 16:03 ` [PATCH 0/1] (Was: [regression] boot failure on alpha, bisected) Oleg Nesterov
2012-10-12 16:03 ` [PATCH 1/1] task_work: Add local_irq_enable() into task_work_run() Oleg Nesterov
2012-10-13 1:09 ` Linus Torvalds
2012-10-13 1:48 ` Al Viro
2012-10-13 9:59 ` Michael Cree
2012-10-13 15:39 ` Al Viro
2012-10-13 13:06 ` Thorsten Kranzkowski
2012-10-12 22:18 ` [PATCH 0/1] (Was: [regression] boot failure on alpha, bisected) Al Viro
2012-10-14 18:35 ` Oleg Nesterov
2012-10-14 18:42 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121007194147.GA931@ds20.borg.net \
--to=dl8bcu@dl8bcu.de \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rth@twiddle.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox