From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754671Ab2JHSx4 (ORCPT ); Mon, 8 Oct 2012 14:53:56 -0400 Received: from fieldses.org ([174.143.236.118]:45330 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088Ab2JHSxx (ORCPT ); Mon, 8 Oct 2012 14:53:53 -0400 Date: Mon, 8 Oct 2012 14:53:47 -0400 From: "J. Bruce Fields" To: Namjae Jeon Cc: hirofumi@mail.parknet.co.jp, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, Namjae Jeon , Ravishankar N , Amit Sahrawat Subject: Re: [PATCH v4 4/4] Documentation: update nfs option in filesystem/vfat.txt Message-ID: <20121008185347.GA5574@fieldses.org> References: <1349598782-3286-1-git-send-email-linkinjeon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1349598782-3286-1-git-send-email-linkinjeon@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 07, 2012 at 04:33:02AM -0400, Namjae Jeon wrote: > From: Namjae Jeon > > update nfs option in filesystem/vfat.txt > > Signed-off-by: Namjae Jeon > Signed-off-by: Ravishankar N > Signed-off-by: Amit Sahrawat > --- > Documentation/filesystems/vfat.txt | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/Documentation/filesystems/vfat.txt b/Documentation/filesystems/vfat.txt > index de1e6c4..d62f8e6 100644 > --- a/Documentation/filesystems/vfat.txt > +++ b/Documentation/filesystems/vfat.txt > @@ -141,13 +141,26 @@ discard -- If set, issues discard/TRIM commands to the block > device when blocks are freed. This is useful for SSD devices > and sparse/thinly-provisoned LUNs. > > -nfs -- This option maintains an index (cache) of directory > - inodes by i_logstart which is used by the nfs-related code to > - improve look-ups. > - > - Enable this only if you want to export the FAT filesystem > +nfs= stale_rw|nostale_ro > + -- Enable this only if you want to export the FAT filesystem > over NFS > > + stale_rw:This option maintains an index (cache) of directory > + inodes by i_logstart which is used by the nfs-related code to > + improve look-ups.Full file operations (read/write) over NFS is supported > + but with cache eviction at NFS server, this could result in ESTALE issues. > + > + nostale_ro:This option bases the inode number and filehandle on the on-disk > + location of a file in the MS-DOS directory entry.This ensures that ESTALE > + will not be returned after a file is evicted from the inode cache. However, > + it means that operations such as rename, create and unlink could cause > + filehandles that previously pointed at one file to point at a different file, > + potentially causing data corruption. For this reason, this option also mounts > + the filesystem readonly. > + > + To maintain backward compatibility, '-o nfs' is also accepted, defaulting to > + stale_rw > + The documentation makes more sense to me now, thanks. --b.