From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc()
Date: Tue, 9 Oct 2012 16:13:45 +0900 [thread overview]
Message-ID: <20121009071343.GW8237@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACVXFVOT+_nWxZOV0hckVrJwafgb_qr35eKaYg9j=toEJ2DNMQ@mail.gmail.com>
On Tue, Oct 09, 2012 at 03:05:30PM +0800, Ming Lei wrote:
> On Tue, Oct 9, 2012 at 12:19 PM, Mark Brown
> > It seems better to punt that decision to callers - for example, the case
> In fact, -ENOENT is returned to caller for non-direct loading situation,
> see_request_firmware_load().
> I understand drivers(caller) may be cheated if a zero-length firmware
> image is obtained. In normal situation, one firmware image should
> include something, instead of nothing, :-)
Hrm, that didn't seem to be happening for me - the firmware load
completed successfully. Have to check how that happened.
> > I ran into this with was a driver that was using a zero length firmware
> > to say that it didn't want to load an optional image but also didn't
> > want to have to time out if that was the case. That doesn't seem
> If so, I am wondering why the driver has to call request_firmware()?
> Looks just bypassing request_firmware() is fine for the driver, doesn't it?
A driver has no way to tell if the firmware is there or not without
asking for it.
next prev parent reply other threads:[~2012-10-09 7:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 17:05 [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc() Mark Brown
2012-10-08 22:56 ` Ming Lei
2012-10-09 4:19 ` Mark Brown
2012-10-09 7:05 ` Ming Lei
2012-10-09 7:13 ` Mark Brown [this message]
2012-10-09 7:34 ` Ming Lei
2012-10-09 7:52 ` Mark Brown
2012-10-09 12:02 ` Ming Lei
2012-10-09 12:36 ` Mark Brown
2012-10-09 14:55 ` Ming Lei
2012-10-10 1:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009071343.GW8237@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).