Re: [PATCH 1/2] mm: Export vm_committed_as

Andrew Morton
2012-11-05T21:44:59Z

On Sat, 3 Nov 2012 14:09:38 +0000
KY Srinivasan <kys@microsoft.com> wrote:

>
>
> > >
> > > Ok, but you're going to have to get the -mm developers to agree that
> > > this is ok before I can accept it.
> >
> > Well I guess it won't kill us.
>
> Andrew,
>
> I presumed this was an Ack from you with regards to exporting the
> symbol. Looks like Greg is waiting to hear from you before he can check
> these patches in. Could you provide an explicit Ack.
>

Well, I do have some qualms about exporting vm_committed_as to modules.

vm_committed_as is a global thing and only really makes sense in a
non-containerised system. If the application is running within a
memory cgroup then vm_enough_memory() and the global overcommit policy
are at best irrelevant and misleading.

If use of vm_committed_as is indeed a bad thing, then exporting it to
modules might increase the amount of badness in the kernel.

I don't think these qualms are serious enough to stand in the way of
this patch, but I'd be interested in hearing the memcg developers'
thoughts on the matter?

Perhaps you could provide a detailed description of why your module
actually needs this? Precisely what information is it looking for
and why? If we know that then perhaps a more comfortable alternative
can be found.