RE: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

KY Srinivasan
2012-10-08T14:54:03Z

> -----Original Message-----
> From: Rusty Russell [mailto:rusty@ozlabs.org]
> Sent: Monday, October 08, 2012 1:46 AM
> To: KY Srinivasan; gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> akpm@linux-foundation.org; andi@firstfloor.org
> Cc: KY Srinivasan
> Subject: Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver
>
> "K. Y. Srinivasan" <kys@microsoft.com> writes:
> > +static int hot_add;
> > +
> > +module_param(hot_add, int, S_IRUGO);
> > +MODULE_PARM_DESC(hot_add, "If set attempt memory hot_add");
>
> I think this should be a 'bool', but I can't tell, since it's not used
> in this patch.

You are right; currently, I unconditionally fail the hot add request. Hopefully,
I will soon be able to support hot add once I get the needed host side
changes.

Regards,

K. Y