From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc()
Date: Wed, 10 Oct 2012 10:55:31 +0900 [thread overview]
Message-ID: <20121010015529.GC17288@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACVXFVNZPxG3pNnQfSEqvPvLV3LoutFCX_0eZpwjAWEwd8RByA@mail.gmail.com>
On Tue, Oct 09, 2012 at 10:55:17PM +0800, Ming Lei wrote:
> On Tue, Oct 9, 2012 at 8:36 PM, Mark Brown
> > On Tue, Oct 09, 2012 at 08:02:18PM +0800, Ming Lei wrote:
> > It doesn't really help as the ABI is such that you can only have one
> Could you let me know where the ABI is?
It's defined by firmware_class?
> > request_firmware() in play at once (unless this changed since I last
> > looked at it).
> I guess you mean that only one firmware device can be added
> as child of the device which is requesting firmware.
> The commit below(already merged into linus tree) should fix
> the problem:
> 99c2aa72306079976369aad7fc62cc71931d692a(firmware loader:
> fix creation failure of fw loader device)
That's not been well advertised (and is extremely recent too)...
> Could you test it to see if more than one request_firmware_nowait()
> can be called concurrently for the same device?
Not for some time.
prev parent reply other threads:[~2012-10-10 1:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 17:05 [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc() Mark Brown
2012-10-08 22:56 ` Ming Lei
2012-10-09 4:19 ` Mark Brown
2012-10-09 7:05 ` Ming Lei
2012-10-09 7:13 ` Mark Brown
2012-10-09 7:34 ` Ming Lei
2012-10-09 7:52 ` Mark Brown
2012-10-09 12:02 ` Ming Lei
2012-10-09 12:36 ` Mark Brown
2012-10-09 14:55 ` Ming Lei
2012-10-10 1:55 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010015529.GC17288@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).