From: Borislav Petkov <bp@amd64.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/3] Convert mce_disabled
Date: Wed, 10 Oct 2012 17:53:48 +0200 [thread overview]
Message-ID: <20121010155348.GE25878@aftab.osrc.amd.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F19D49FC7@ORSMSX108.amr.corp.intel.com>
On Wed, Oct 10, 2012 at 03:46:39PM +0000, Luck, Tony wrote:
> struct mca_config {
> - u64 dont_log_ce : 1,
> -#define MCA_CFG_DONT_LOG_CE 0
> - __resv1 : 63;
> + u64 dont_log_ce : 1,
> +#define MCA_CFG_DONT_LOG_CE 0
> + mca_disabled : 1,
> +#define MCA_CFG_MCA_DISABLED 1
> + __resv1 : 62;
> };
>
> If we do head in this direction - I don't think it is useful to change just one bit
> on each commit. We should batch in larger groups.
Sure, this is just sanity-checking-the-approach patchset, trying to make
the intent as understandable as possible. The real thing should do a
couple of conversions in one patch, of course.
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2012-10-10 15:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 14:19 [RFC PATCH 0/3] mca_config stuff Borislav Petkov
2012-10-10 14:19 ` [RFC PATCH 1/3] Add DEVICE_BIT_ATTR Borislav Petkov
2012-10-10 14:20 ` [RFC PATCH 2/3] Change mce_dont_log_ce Borislav Petkov
2012-10-10 14:20 ` [RFC PATCH 3/3] Convert mce_disabled Borislav Petkov
2012-10-10 15:46 ` Luck, Tony
2012-10-10 15:53 ` Borislav Petkov [this message]
2012-10-12 10:50 ` Naveen N. Rao
2012-10-12 11:56 ` Borislav Petkov
2012-10-12 17:46 ` Luck, Tony
2012-10-12 21:58 ` Borislav Petkov
2012-10-15 5:53 ` Naveen N. Rao
2012-10-10 15:35 ` [RFC PATCH 0/3] mca_config stuff Luck, Tony
2012-10-10 19:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010155348.GE25878@aftab.osrc.amd.com \
--to=bp@amd64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox