From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@stericsson.com
Subject: Re: [PATCH 6/6] mfd: Differentiate between u8500 and u9540 TCDM address mapping
Date: Wed, 10 Oct 2012 18:34:40 +0000 [thread overview]
Message-ID: <201210101834.40749.arnd@arndb.de> (raw)
In-Reply-To: <1349882335-6786-7-git-send-email-lee.jones@linaro.org>
On Wednesday 10 October 2012, Lee Jones wrote:
> @@ -2688,7 +2688,11 @@ void __init db8500_prcmu_early_init(void)
> iounmap(tcpm_base);
> }
>
> - tcdm_base = __io_address(U8500_PRCMU_TCDM_BASE);
> + if (cpu_is_u9540())
> + tcdm_base = ioremap_nocache(U8500_PRCMU_TCDM_BASE,
> + SZ_4K + SZ_8K) + SZ_8K;
> + else
> + tcdm_base = __io_address(U8500_PRCMU_TCDM_BASE);
> } else {
> pr_err("prcmu: Unsupported chip version\n");
> BUG();
Would it be possible to get the base out of the device tree and always
map it from there? Adding another dependency on a fixed constant is
just going to make the conversion to multiplatform harder, since it
was decided that device drivers should not have access to platform
header files in the multiplatform case.
Arnd
next prev parent reply other threads:[~2012-10-10 18:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 15:18 [PATCH 0/6] Provide basic support for the u9540 Lee Jones
2012-10-10 15:18 ` [PATCH 1/6] ARM: ux500: Remove unused board compatible string Lee Jones
2012-10-10 15:18 ` [PATCH 2/6] ARM: ux500: Add skeleton DTS file for the u9540 Lee Jones
2012-10-10 15:18 ` [PATCH 3/6] ARM: ux500: Add support for ST-Ericsson's u9540 SoC Lee Jones
2012-10-10 19:01 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-11 7:38 ` Lee Jones
2012-10-11 8:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-11 9:20 ` Lee Jones
2012-10-11 18:11 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-10 15:18 ` [PATCH 4/6] ARM: ux500: Add UART support to the u9540 Device Tree Lee Jones
2012-10-10 19:03 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-11 7:29 ` Lee Jones
2012-10-11 8:50 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-11 9:22 ` Lee Jones
2012-10-11 18:06 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-12 21:15 ` Linus Walleij
2012-10-10 15:18 ` [PATCH 5/6] ARM: ux500: Enable SDI4 port on the u9540 when booting with " Lee Jones
2012-10-10 19:04 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-11 7:28 ` Lee Jones
2012-10-10 15:18 ` [PATCH 6/6] mfd: Differentiate between u8500 and u9540 TCDM address mapping Lee Jones
2012-10-10 18:34 ` Arnd Bergmann [this message]
2012-10-11 8:59 ` Lee Jones
2012-10-11 9:16 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210101834.40749.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox