Re: [ 011/120] lib/gcd.c: prevent possible div by 0

Greg Kroah-Hartman
2012-10-12T21:16:10Z

On Fri, Oct 12, 2012 at 10:11:24PM +0100, Ben Hutchings wrote:
> On Thu, 2012-10-11 at 09:59 +0900, Greg Kroah-Hartman wrote:
> > 3.4-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Davidlohr Bueso <dave@gnu.org>
> >
> > commit e96875677fb2b7cb739c5d7769824dff7260d31d upstream.
> >
> > Account for all properties when a and/or b are 0:
> > gcd(0, 0) = 0
> > gcd(a, 0) = a
> > gcd(0, b) = b
> >
> > Fixes no known problems in current kernels.
> [...]
>
> I can't believe this change is harmful, but unless there are some known
> problems this doesn't meet the criteria for a stable update.

It was discussed in the original thread of this patch that it would be a
good idea to have this in the stable releases, and I agree.

greg k-h