From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: ciminaghi@gnudd.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap : make lock/unlock functions customizable.
Date: Fri, 12 Oct 2012 15:26:09 +0900 [thread overview]
Message-ID: <20121012062607.GN11726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1349127064-432-1-git-send-email-ciminaghi@gnudd.com>
On Mon, Oct 01, 2012 at 11:31:04PM +0200, ciminaghi@gnudd.com wrote:
> From: Davide Ciminaghi <ciminaghi@gnudd.com>
>
> It is sometimes convenient for a regmap user to override the standard
> regmap lock/unlock functions with custom functions.
This looks good overall but...
> -static void regmap_lock_mutex(struct regmap *map)
> +static void regmap_lock_mutex(void *__map)
> {
> + struct regmap *map = (struct regmap *)__map;
> mutex_lock(&map->mutex);
...you should never need to cast away from or to void, if you do there's
a bug somewhere.
next prev parent reply other threads:[~2012-10-12 6:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 21:31 [PATCH] regmap : make lock/unlock functions customizable ciminaghi
2012-10-12 6:26 ` Mark Brown [this message]
2012-10-12 8:24 ` Davide Ciminaghi
2012-10-15 0:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012062607.GN11726@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ciminaghi@gnudd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox