Re: [PATCH 1/1] task_work: Add local_irq_enable() into task_work_run()

Al Viro
2012-10-13T01:49:03Z

On Sat, Oct 13, 2012 at 10:09:36AM +0900, Linus Torvalds wrote:
> On Sat, Oct 13, 2012 at 1:03 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> > arch/alpha and probably some other architectures call
> > do_notify_resume()->task_work_run() with irqs disabled.
>
> I'm going to ignore this patch because I *hope* it is unnecessary
> after the pull from Al that I just did.
>
> But if that turns out to be not the case, please holler. Torsten, you
> seem to be the one who reported this, can you check the current git
> tree?

For alpha it shouldn't be needed, but it's a good idea in general -
it detects bugs of that kind we might very well have on some other
architectures, warns about them and attempts to minimize the damage.
I think x86, arm, sparc, ppc, s390, x86, mips and m68k are OK, judging
by the local testing I've done (alpha did trigger that mess during the
same testing, until I'd added those patches). As for everything else...
no idea at the moment. Unfortunately, TFS to read through for that
includes an unhealthy amount of asm glue on all sorts of strange
architectures ;-/