Re: [PATCH V2 3/3] ARM: SPEAr13xx: Pass DW DMAC platform data from DT

Viresh Kumar
2012-10-13T14:10:55Z

On 13 October 2012 19:38, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 13 October 2012 17:52, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
>> On 14:18 Sat 13 Oct , Viresh Kumar wrote:
>>> On Oct 13, 2012 12:16 PM, "Jean-Christophe PLAGNIOL-VILLARD"
>>> <plagnioj@jcrosoft.com> wrote:
>>> >
>>> > On 22:42 Fri 12 Oct , Viresh Kumar wrote:
>>> > > On 12 October 2012 21:51, Jean-Christophe PLAGNIOL-VILLARD
>>> > > <plagnioj@jcrosoft.com> wrote:
>>> > > >> >> + OF_DEV_AUXDATA("arasan,cf-spear1340", MCIF_CF_BASE, NULL,
>>> "cf"),
>>> > > >> > ?/
>>> > > >>
>>> > > >> Sorry. can't get it :(
>>> > > > what is the "cf" as paltfrom data
>>> > >
>>> > > This is dma bus_id string, which matches with what is passed from dtb.
>>> > so pass if via dtb too
>>>
>>> Yes. Already passed in 13xx.dtsi.

Probably some confusion here. What i meant to say here is, dmac's
DT slave info has a node for cf and cf driver expects this string to come
via platform data currently.

>> so why do you keep the AUXDATA
>
> Because the compact flash driver expects it via platform data and not
> via DT. yes, it
> can be changed, but that wasn't the target of this patchset. If it has
> to be done, then
> it has to be done separately by ST guys.

--
viresh