public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sangho Yi <antiroot@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: Staging: CSR: Fixed coding style warnings
Date: Sun, 14 Oct 2012 06:07:57 -0700	[thread overview]
Message-ID: <20121014130757.GA11575@kroah.com> (raw)
In-Reply-To: <1350218909-20801-1-git-send-email-antiroot@gmail.com>

On Sun, Oct 14, 2012 at 09:48:29PM +0900, Sangho Yi wrote:
> On drivers/staging/csr/csr_time.h, there were a few warnings on
> indentation, braces, and typedef struct usage.
> All those were changed to the proper way.

No, as I explained in the talk, only do one thing at a time here.

So, one patch for the indentation, one patch for the braces, and then,
one patch for the typedef.

And, with the typedef change, did you just break the build?  If not,
then the whole structure can be removed, right?

So, care to redo this?

thanks,

greg k-h

  reply	other threads:[~2012-10-14 13:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-14 12:48 [PATCH] Drivers: Staging: CSR: Fixed coding style warnings Sangho Yi
2012-10-14 13:07 ` Greg KH [this message]
2012-10-18 13:28 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121014130757.GA11575@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=antiroot@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox