From: Aristeu Rozanski <aris@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Tejun Heo <tj@kernel.org>,
dan.carpenter@oracle.com, fengguang.wu@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] xattr: prevent NULL ptr deref warnings in __simple_xattr_set
Date: Mon, 15 Oct 2012 09:16:36 -0400 [thread overview]
Message-ID: <20121015131636.GD29956@redhat.com> (raw)
In-Reply-To: <5074725F.6090804@gmail.com>
Sasha,
On Tue, Oct 09, 2012 at 02:52:15PM -0400, Sasha Levin wrote:
> On 09/14/2012 04:58 PM, Aristeu Rozanski wrote:
> > On Fri, Sep 14, 2012 at 01:55:55PM -0700, Tejun Heo wrote:
> >> On Fri, Sep 14, 2012 at 01:54:34PM -0700, Tejun Heo wrote:
> >>> On Fri, Sep 14, 2012 at 09:35:54PM +0200, Sasha Levin wrote:
> >>>> Prevent warnings generated by smatch due to unchecked dereference of
> >>>> 'new_xattr' in __simple_xattr_set().
> >>>
> >>> Isn't this an actual bug w/ or w/o smatch? Remove request (NULL
> >>> @value) w/o XATTR_REPLACE for an non-existent node would end up
> >>> calling list_add() on NULL, right? If so, please collapse these two
> >>> patches and mention the actual bug instead of smatch warning.
> >>
> >> And can somebody please make that function less confusing? -
> >> restructuring / commenting whatever. It's doing something simple.
> >> It's not supposed to be this confusing.
> >
> > I'll work on that.
> >
>
> As it's still happening in linux-next, should I send a simple patch to fix it along
> with Tejun's comments? Or is the rewrite of __simple_xattr_set() behind the corner?
the problem isn't because of the way __simple_xattr_set(), but because
the fix took another route and wasn't present when you hit it last.
--
Aristeu
next prev parent reply other threads:[~2012-10-15 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 19:35 [PATCH 1/2] Revert "xattr: mark variable as uninitialized to make both gcc and smatch happy" Sasha Levin
2012-09-14 19:35 ` [PATCH 2/2] xattr: prevent NULL ptr deref warnings in __simple_xattr_set Sasha Levin
2012-09-14 20:54 ` Tejun Heo
2012-09-14 20:55 ` Tejun Heo
2012-09-14 20:58 ` Aristeu Rozanski
2012-10-09 18:52 ` Sasha Levin
2012-10-15 13:16 ` Aristeu Rozanski [this message]
2012-09-14 20:05 ` [PATCH 1/2] Revert "xattr: mark variable as uninitialized to make both gcc and smatch happy" Aristeu Rozanski
2012-09-15 12:43 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015131636.GD29956@redhat.com \
--to=aris@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox