public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Bisected regression in Linux 3.7.0-rc1, hang on login caused by replace_fd()
Date: Mon, 15 Oct 2012 19:40:08 -0400	[thread overview]
Message-ID: <20121015194008.29e38086@mj> (raw)
In-Reply-To: <20121015232705.GM2616@ZenIV.linux.org.uk>

On Tue, 16 Oct 2012 00:27:05 +0100
Al Viro <viro@ZenIV.linux.org.uk> wrote:

> 	I think I understand what's going on there.  Add
> fput(files[0]) after that replace_fd(); we have a leak and while
> that's not the right way to fix it, that'd verify if anything else is
> going on there.

Yes, it's working now!  No more hang on login!

-- 
Regards,
Pavel Roskin

  reply	other threads:[~2012-10-15 23:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15 21:14 Bisected regression in Linux 3.7.0-rc1, hang on login caused by replace_fd() Pavel Roskin
2012-10-15 21:51 ` Al Viro
2012-10-15 23:11   ` Pavel Roskin
2012-10-15 23:27     ` Al Viro
2012-10-15 23:40       ` Pavel Roskin [this message]
2012-10-15 23:48         ` Al Viro
2012-10-16 15:02           ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121015194008.29e38086@mj \
    --to=proski@gnu.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox