From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Stanislav Kinsbursky <skinsbursky@parallels.com>,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
criu@openvz.org, ebiederm@xmission.com, rientjes@google.com,
devel@openvz.org
Subject: Re: [PATCH] proc: check vma->vm_file before dereferencing
Date: Tue, 16 Oct 2012 01:52:30 +0400 [thread overview]
Message-ID: <20121015215230.GP19449@moon> (raw)
In-Reply-To: <20121015144048.8fa16d28.akpm@linux-foundation.org>
On Mon, Oct 15, 2012 at 02:40:48PM -0700, Andrew Morton wrote:
> On Mon, 15 Oct 2012 19:30:03 +0400
> Stanislav Kinsbursky <skinsbursky@parallels.com> wrote:
>
> > It can be equal to NULL.
> >
>
> Please write better changelogs, so people do not have to ask questions
> such as:
>
> - Under what conditions does this bug trigger?
>
> - In which kernel version(s)?
>
> - Is it a post-3.6 regression?
Andrew, would the following changelog be enough?
The commit 7b540d0646ce122f0ba4520412be91e530719742 switched
proc_map_files_readdir to use @f_mode directly instead of grabbing
@file reference, but same time the test for @vm_file presence was
lost leading to nil dereference. The patch brings the test back.
The all proc_map_files feature is CONFIG_CHECKPOINT_RESTORE wrapped
(which is set to 'n' by default) so the bug doesn't affect regular
kernels.
The regression is 3.7-rc1 only as far as I can tell.
next prev parent reply other threads:[~2012-10-15 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 15:30 [PATCH] proc: check vma->vm_file before dereferencing Stanislav Kinsbursky
2012-10-15 15:30 ` Cyrill Gorcunov
2012-10-15 21:40 ` Andrew Morton
2012-10-15 21:52 ` Cyrill Gorcunov [this message]
2012-10-15 22:04 ` Andrew Morton
2012-10-16 7:26 ` Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015215230.GP19449@moon \
--to=gorcunov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=criu@openvz.org \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=skinsbursky@parallels.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox