From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Yadwinder Singh Brar <yadi.brar@samsung.com>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/2] regulator: core: Check before enabling regulator while setting constraints.
Date: Tue, 16 Oct 2012 14:35:00 +0900 [thread overview]
Message-ID: <20121016053458.GD8670@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1350365059-18838-1-git-send-email-yadi.brar@samsung.com>
On Tue, Oct 16, 2012 at 10:54:19AM +0530, Yadwinder Singh Brar wrote:
> This patch adds check, whether regulator is already enabled before enabling it
> while setting machine constraints. Since some PMICs have same register bits
> for setting opmode and enabling/disabling the regulator, so it will overwrite
> the settings (if any)done by set_mode/set_suspend_mode callbacks when it
> enables regulator without checking previous status.
This sounds like a bug in the driver, these ops are supposed to be
repeatable at will. The driver needs to remember the mode setting when
doing enable or disable, and setting the mode should not change the
enable status.
prev parent reply other threads:[~2012-10-16 5:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 5:24 [PATCH 1/2] regulator: core: Check before enabling regulator while setting constraints Yadwinder Singh Brar
2012-10-16 5:35 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016053458.GD8670@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=yadi.brar@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox