public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Howells <dhowells@redhat.com>
Subject: Re: [RFC PATCH 1/5] irq_work: Move irq_work_raise() declaration/default definition to arch headers
Date: Tue, 16 Oct 2012 09:25:11 +0000	[thread overview]
Message-ID: <201210160925.11891.arnd@arndb.de> (raw)
In-Reply-To: <20121016031240.GA4804@opensource.wolfsonmicro.com>

On Tuesday 16 October 2012, Mark Brown wrote:
> On Tue, Oct 16, 2012 at 12:18:05AM +0200, Frederic Weisbecker wrote:
> 
> I came up with stuff for it, though it needed prettyfying.
> 
> > This seems to do the trick:
> 
> > (It's the diff result of ln -s asm-generic include/asm)

Unfortunately, this is not enough, it breaks "make headers_install",
which now needs to decide whether to install a header that is present
in the architecture directory, or to copy one from the asm-generic
directory otherwise.

On the plus side, the symlink breaks checking into CVS and cross-building
from operating systems that don't support posix file systems, so we
might want to do this anyway. ;-)

> That'd work, but I assume there is some reason why we've got this system
> of explicitly adding each file.  It's not like cpp can test for the
> presence of include files.  If we can't figure out why we're not doing
> this I'd propose we start.

We discussed renaming asm-generic to asm before, but some people objected
to the use of #include_next. There is a smaller problem with opening the
asm/*.h namespace to header files that are not relevant for architctures,
so I'd prefer to have a well-defined list of headers that are implicitly
shared, but it's not a technical argument.

	Arnd

  reply	other threads:[~2012-10-16  9:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12 18:09 [RFC PATCH 0/5] printk: Make it usable on nohz CPUs Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 1/5] irq_work: Move irq_work_raise() declaration/default definition to arch headers Frederic Weisbecker
2012-10-15 16:11   ` Catalin Marinas
2012-10-15 20:02     ` Steven Rostedt
2012-10-15 20:23       ` Frederic Weisbecker
2012-10-15 20:39         ` Steven Rostedt
2012-10-15 21:34           ` Arnd Bergmann
2012-10-15 22:18             ` Frederic Weisbecker
2012-10-16  3:12               ` Mark Brown
2012-10-16  9:25                 ` Arnd Bergmann [this message]
2012-10-16 15:40                   ` Mark Brown
2012-10-12 18:09 ` [RFC PATCH 2/5] irq_work: Only run irq_work from tick if arch needs it Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 3/5] x86: Implement arch_irq_work_use_tick Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 4/5] nohz: Add API to check tick state Frederic Weisbecker
2012-10-12 18:09 ` [RFC PATCH 5/5] printk: Wake up klogd with irq_work on nohz CPU Frederic Weisbecker
2012-10-19 15:50 ` [RFC PATCH 0/5] printk: Make it usable on nohz CPUs Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210160925.11891.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=catalin.marinas@arm.com \
    --cc=dhowells@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox