public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tom Mingarelli <thomas.mingarelli@hp.com>
To: Alex Williamson <alex.williamson@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Don Dutile <ddutile@redhat.com>
Cc: Shuah Khan <shuah.khan@hp.com>,
	Tom Mingarelli <thomas.mingarelli@hp.com>,
	Linda Knippers <linda.knippers@hp.com>,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3] Prevent devices with RMRRs from being placed into SI Domain during startup
Date: Tue, 16 Oct 2012 16:50:29 +0000 (UTC)	[thread overview]
Message-ID: <20121016164905.14478.21080.sendpatchset@RHEL63BL460c.osen.hp.com> (raw)

This patch is to prevent devices that have RMRRs associated with them 
from getting placed into the SI Domain during init. We don't put USB devices
into this category, however. This fixes the issue where the RMRR info
for devices being placed in and out of the SI Domain gets lost.

Signed-off-by: Thomas Mingarelli <thomas.mingarelli@hp.com>
----
PATCH v1: https://lkml.org/lkml/2012/6/15/204
PATCH v2: https://lkml.org/lkml/2012/9/18/354

drivers/iommu/intel-iommu.c |   33 +++++++++++++++++++++++++++++++++
1 files changed, 33 insertions(+), 0 deletions(-)

diff -up ./drivers/iommu/intel-iommu.c.ORIG ./drivers/iommu/intel-iommu.c
--- ./drivers/iommu/intel-iommu.c.ORIG	2012-10-16 09:34:23.148089944 -0500
+++ ./drivers/iommu/intel-iommu.c	2012-10-16 09:56:56.905932861 -0500
@@ -2320,8 +2320,41 @@ static int domain_add_dev_info(struct dm
 	return 0;
 }
 
+static bool device_has_rmrr(struct pci_dev *dev)
+{
+	struct dmar_rmrr_unit *rmrr;
+	int i;
+
+	for_each_rmrr_units(rmrr) {
+		for (i = 0; i < rmrr->devices_cnt; i++) {
+			/*
+			 * Here we are just concerned with checking each device
+			 * that has an RMRR associated with it and not allow it
+			 * to be placed into the SI Domain during startup.
+			*/
+			if (rmrr->devices[i] == dev)
+				return true;
+		}
+	}
+	return false;
+}
+
 static int iommu_should_identity_map(struct pci_dev *pdev, int startup)
 {
+
+	if (startup) {
+		/*
+		 * This is where we will refuse any device that has an
+		 * RMRR associated with it and is not a USB device and
+		 * NOT allow it to be placed into the SI Domain. We
+		 * only do this on startup. We don't need a separate bit
+		 * for this because it could be ANY device.
+		*/
+		if (device_has_rmrr(pdev) &&
+			(pdev->class >> 8) != PCI_CLASS_SERIAL_USB)
+				return 0;
+	}
+
 	if ((iommu_identity_mapping & IDENTMAP_AZALIA) && IS_AZALIA(pdev))
 		return 1;
 

             reply	other threads:[~2012-10-16 16:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16 16:50 Tom Mingarelli [this message]
2012-10-16 16:59 ` [PATCH v3] Prevent devices with RMRRs from being placed into SI Domain during startup Alex Williamson
2012-10-16 17:38   ` Mingarelli, Thomas
2012-10-16 17:26 ` Shuah Khan
2012-10-16 17:40   ` Mingarelli, Thomas
2012-10-16 17:28 ` Shuah Khan
2012-10-16 17:41   ` Mingarelli, Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121016164905.14478.21080.sendpatchset@RHEL63BL460c.osen.hp.com \
    --to=thomas.mingarelli@hp.com \
    --cc=alex.williamson@redhat.com \
    --cc=ddutile@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linda.knippers@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shuah.khan@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox