* [PATCH 1/2] backlight: lms283gf05: use devm_gpio_request_one
@ 2012-10-17 5:49 Jingoo Han
2012-10-17 7:01 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2012-10-17 5:49 UTC (permalink / raw)
To: 'Andrew Morton', 'LKML'
Cc: 'Richard Purdie', 'Marek Vasut',
'Jingoo Han'
By using devm_gpio_request_one it is possible to set the direction
and initial value in one shot. Thus, using devm_gpio_request_one
can make the code simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Marek Vasut <marek.vasut@gmail.com>
---
drivers/video/backlight/lms283gf05.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/video/backlight/lms283gf05.c b/drivers/video/backlight/lms283gf05.c
index ea43f22..c452210 100644
--- a/drivers/video/backlight/lms283gf05.c
+++ b/drivers/video/backlight/lms283gf05.c
@@ -158,13 +158,9 @@ static int __devinit lms283gf05_probe(struct spi_device *spi)
int ret = 0;
if (pdata != NULL) {
- ret = devm_gpio_request(&spi->dev, pdata->reset_gpio,
- "LMS285GF05 RESET");
- if (ret)
- return ret;
-
- ret = gpio_direction_output(pdata->reset_gpio,
- !pdata->reset_inverted);
+ ret = devm_gpio_request_one(&spi->dev, pdata->reset_gpio,
+ GPIOF_DIR_OUT | !pdata->reset_inverted,
+ "LMS285GF05 RESET");
if (ret)
return ret;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] backlight: lms283gf05: use devm_gpio_request_one
2012-10-17 5:49 [PATCH 1/2] backlight: lms283gf05: use devm_gpio_request_one Jingoo Han
@ 2012-10-17 7:01 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2012-10-17 7:01 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', 'LKML', 'Richard Purdie'
Dear Jingoo Han,
> By using devm_gpio_request_one it is possible to set the direction
> and initial value in one shot. Thus, using devm_gpio_request_one
> can make the code simpler.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: Marek Vasut <marek.vasut@gmail.com>
Acked-by: Marek Vasut <marex@denx.de>
> ---
> drivers/video/backlight/lms283gf05.c | 10 +++-------
> 1 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/video/backlight/lms283gf05.c
> b/drivers/video/backlight/lms283gf05.c index ea43f22..c452210 100644
> --- a/drivers/video/backlight/lms283gf05.c
> +++ b/drivers/video/backlight/lms283gf05.c
> @@ -158,13 +158,9 @@ static int __devinit lms283gf05_probe(struct
> spi_device *spi) int ret = 0;
>
> if (pdata != NULL) {
> - ret = devm_gpio_request(&spi->dev, pdata->reset_gpio,
> - "LMS285GF05 RESET");
> - if (ret)
> - return ret;
> -
> - ret = gpio_direction_output(pdata->reset_gpio,
> - !pdata->reset_inverted);
> + ret = devm_gpio_request_one(&spi->dev, pdata->reset_gpio,
> + GPIOF_DIR_OUT | !pdata->reset_inverted,
> + "LMS285GF05 RESET");
> if (ret)
> return ret;
> }
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-17 7:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-17 5:49 [PATCH 1/2] backlight: lms283gf05: use devm_gpio_request_one Jingoo Han
2012-10-17 7:01 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox