* [PATCH 1/1] regmap: select REGMAP if REGMAP_MMIO and REGMAP_IRQ enabled
@ 2012-10-15 7:50 Dong Aisheng
2012-10-17 13:10 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Dong Aisheng @ 2012-10-15 7:50 UTC (permalink / raw)
To: linux-kernel; +Cc: broonie, sameo, fengguang.wu, rdunlap, gregkh, swarren
From: Dong Aisheng <dong.aisheng@linaro.org>
The regmap_mmio and regmap_irq depend on regmap core, if not select,
we may not compile regmap core and meet compiling errors as follows
if REGMAP_MMIO is selected by client drivers:
drivers/mfd/syscon.c:94:15: error: variable 'syscon_regmap_config' has initializer but incomplete type
drivers/mfd/syscon.c:95:2: error: unknown field 'reg_bits' specified in initializer
drivers/mfd/syscon.c:95:2: warning: excess elements in struct initializer [enabled by default]
drivers/mfd/syscon.c:95:2: warning: (near initialization for 'syscon_regmap_config') [enabled by default]
drivers/mfd/syscon.c:96:2: error: unknown field 'val_bits' specified in initializer
drivers/mfd/syscon.c:96:2: warning: excess elements in struct initializer [enabled by default]
drivers/mfd/syscon.c:96:2: warning: (near initialization for 'syscon_regmap_config') [enabled by default]
drivers/mfd/syscon.c:97:2: error: unknown field 'reg_stride' specified in initializer
drivers/mfd/syscon.c:97:2: warning: excess elements in struct initializer [enabled by default]
drivers/mfd/syscon.c:97:2: warning: (near initialization for 'syscon_regmap_config') [enabled by default]
drivers/mfd/syscon.c: In function 'syscon_probe':
drivers/mfd/syscon.c:124:2: error: invalid use of undefined type 'struct regmap_config'
drivers/mfd/syscon.c:125:2: error: implicit declaration of function 'devm_regmap_init_mmio' [-Werror=implicit-function-declaration]
drivers/mfd/syscon.c:125:17: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
drivers/mfd/Kconfig:
config MFD_SYSCON
bool "System Controller Register R/W Based on Regmap"
depends on OF
select REGMAP_MMIO
help
Select this option to enable accessing system control registers
via regmap.
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
---
drivers/base/regmap/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
index 6be390b..f0d3054 100644
--- a/drivers/base/regmap/Kconfig
+++ b/drivers/base/regmap/Kconfig
@@ -3,7 +3,7 @@
# subsystems should select the appropriate symbols.
config REGMAP
- default y if (REGMAP_I2C || REGMAP_SPI)
+ default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_MMIO || REGMAP_IRQ)
select LZO_COMPRESS
select LZO_DECOMPRESS
select IRQ_DOMAIN if REGMAP_IRQ
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] regmap: select REGMAP if REGMAP_MMIO and REGMAP_IRQ enabled
2012-10-15 7:50 [PATCH 1/1] regmap: select REGMAP if REGMAP_MMIO and REGMAP_IRQ enabled Dong Aisheng
@ 2012-10-17 13:10 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-10-17 13:10 UTC (permalink / raw)
To: Dong Aisheng; +Cc: linux-kernel, sameo, fengguang.wu, rdunlap, gregkh, swarren
On Mon, Oct 15, 2012 at 03:50:25PM +0800, Dong Aisheng wrote:
> From: Dong Aisheng <dong.aisheng@linaro.org>
>
> The regmap_mmio and regmap_irq depend on regmap core, if not select,
> we may not compile regmap core and meet compiling errors as follows
> if REGMAP_MMIO is selected by client drivers:
Applied, thanks.
Please use less random CC lists.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-17 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-15 7:50 [PATCH 1/1] regmap: select REGMAP if REGMAP_MMIO and REGMAP_IRQ enabled Dong Aisheng
2012-10-17 13:10 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).