From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Robin Dong <robin.k.dong@gmail.com>,
linux-kernel@vger.kernel.org, Robin Dong <sanbai@taobao.com>,
Jens Axboe <axboe@kernel.dk>, Tao Ma <boyu.mt@taobao.com>
Subject: Re: [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle
Date: Wed, 17 Oct 2012 09:49:45 -0400 [thread overview]
Message-ID: <20121017134945.GC31663@redhat.com> (raw)
In-Reply-To: <20121016232706.GI16166@google.com>
On Tue, Oct 16, 2012 at 04:27:06PM -0700, Tejun Heo wrote:
[..]
> > Changelog from v2:
> > Use nr-queued[] of struct throtl_grp for stats instaed of adding new blkg_rwstat.
>
> As I wrote last time, I would prefer exposing the total number queued
> to blk-throttle rather than exposing the number of bios being
> currently held and let userland calculate from the difference from
> throttle.io_serviced. That is simpler and more inline with all other
> stats.
Hi Tejun,
Can you explain a bit more. Whe do you mean by "total number queued". I
think throttle.io_queued will total number of bios queued in the cgroup
at the time of query.
Thanks
Vivek
next prev parent reply other threads:[~2012-10-17 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 6:53 [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle Robin Dong
2012-10-10 14:22 ` Vivek Goyal
2012-10-16 23:27 ` Tejun Heo
2012-10-17 13:49 ` Vivek Goyal [this message]
2012-10-18 23:24 ` Tejun Heo
2012-10-19 15:00 ` Vivek Goyal
2012-10-19 19:36 ` Tejun Heo
2012-10-19 19:39 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121017134945.GC31663@redhat.com \
--to=vgoyal@redhat.com \
--cc=axboe@kernel.dk \
--cc=boyu.mt@taobao.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.k.dong@gmail.com \
--cc=sanbai@taobao.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).