From: Jason Baron <jbaron@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dynamic_debug: Remove unnecessary __used
Date: Thu, 18 Oct 2012 15:20:08 -0400 [thread overview]
Message-ID: <20121018192007.GB3703@redhat.com> (raw)
In-Reply-To: <1350587223.5652.4.camel@joe-AO722>
On Thu, Oct 18, 2012 at 12:07:03PM -0700, Joe Perches wrote:
> The __used attribute prevents gcc from eliminating
> unnecessary, otherwise optimized away, metadata for
> debugging logging messages.
>
> Remove the __used attribute.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> include/linux/dynamic_debug.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
> index c18257b..6dd4787 100644
> --- a/include/linux/dynamic_debug.h
> +++ b/include/linux/dynamic_debug.h
> @@ -61,7 +61,7 @@ int __dynamic_netdev_dbg(struct _ddebug *descriptor,
> const char *fmt, ...);
>
> #define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
> - static struct _ddebug __used __aligned(8) \
> + static struct _ddebug __aligned(8) \
> __attribute__((section("__verbose"))) name = { \
> .modname = KBUILD_MODNAME, \
> .function = __func__, \
>
>
Greg, Pls pull this.
Acked-by: Jason Baron <jbaron@redhat.com>
next prev parent reply other threads:[~2012-10-18 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 19:07 [PATCH] dynamic_debug: Remove unnecessary __used Joe Perches
2012-10-18 19:20 ` Jason Baron [this message]
2012-10-18 21:02 ` Greg KH
2012-10-18 19:40 ` Greg KH
2012-10-18 19:59 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018192007.GB3703@redhat.com \
--to=jbaron@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox