From: Tejun Heo <tj@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Li Zefan <lizefan@huawei.com>,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Is not locking task_lock in cgroup_fork() safe?
Date: Thu, 18 Oct 2012 17:38:35 -0700 [thread overview]
Message-ID: <20121019003835.GE13370@google.com> (raw)
In-Reply-To: <CAFTL4hy7g4e11OUOyoihrEU8hiVgZoV1=141UtUpj9a72SNs_Q@mail.gmail.com>
Hello, Frederic.
On Thu, Oct 18, 2012 at 10:53:47PM +0200, Frederic Weisbecker wrote:
> > For now, I'll revert the patches and cc stable. Let's think about
> > improving it later.
>
> Ok for reverting in cgroup_fork(). Is it necessary for the
> cgroup_post_fork() thing? I don't immediately see any race involved
> there.
Even if there isn't an actual race, the comment is dead wrong. I'm
reverting the following three patches. Let's try again later.
7e381b0eb1 ("cgroup: Drop task_lock(parent) on cgroup_fork()")
7e3aa30ac8 ("cgroup: Remove task_lock() from cgroup_post_fork()")
c84cdf75cc ("cgroup: Remove unnecessary task_lock before fetching css_set on migration")
Thanks.
--
tejun
next prev parent reply other threads:[~2012-10-19 0:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121008020000.GB2575@localhost>
[not found] ` <CAFTL4hzXWtzp7megsCAEuak5=_2SWmp9age-+wrpyQAU4BRZ0w@mail.gmail.com>
[not found] ` <20121016193341.GD16166@google.com>
2012-10-18 14:50 ` Is not locking task_lock in cgroup_fork() safe? Frederic Weisbecker
2012-10-18 20:07 ` Tejun Heo
2012-10-18 20:53 ` Frederic Weisbecker
2012-10-19 0:38 ` Tejun Heo [this message]
2012-10-19 0:58 ` Tejun Heo
2012-10-19 8:50 ` Li Zefan
[not found] ` <20121019005922.GG13370@google.com>
[not found] ` <CAFTL4hz82==b3ioSMhbKzh0CN1ivR7RQMKKMFFWu5PHPjg=Bfg@mail.gmail.com>
[not found] ` <20121019193808.GL13370@google.com>
2012-10-19 19:44 ` [PATCH cgroup/for-3.7-fixes 1/2] Revert "cgroup: Remove task_lock() from cgroup_post_fork()" Frederic Weisbecker
2012-10-19 21:07 ` Tejun Heo
2012-10-20 18:21 ` Frederic Weisbecker
2012-10-20 18:23 ` Frederic Weisbecker
2012-10-20 22:37 ` Tejun Heo
2012-10-22 9:30 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121019003835.GE13370@google.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox