Re: [ 09/76] lockd: use rpc clients cl_nodename for id encoding

Ben Hutchings
2012-10-19T22:13:08Z

On Fri, Oct 19, 2012 at 11:10:30PM +0100, Ben Hutchings wrote:
> On Thu, Oct 18, 2012 at 07:46:33PM -0700, Greg Kroah-Hartman wrote:
> > 3.6-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Stanislav Kinsbursky <skinsbursky@parallels.com>
> >
> > commit 303a7ce92064c285a04c870f2dc0192fdb2968cb upstream.
> >
> > Taking hostname from uts namespace if not safe, because this cuold be
> > performind during umount operation on child reaper death. And in this case
> > current->nsproxy is NULL already.
[...]
> > struct nsm_res {
> > @@ -141,6 +142,7 @@ static int nsm_mon_unmon(struct nsm_hand
> > .vers = 3,
> > .proc = NLMPROC_NSM_NOTIFY,
> > .mon_name = nsm->sm_mon_name,
> > + .nodename = utsname()->nodename,
>
> Can we be sure that this string pointer will remain valid at the point
> where current->nsproxy has become NULL? Or should nsm_args::nodename
> actually be a copy of the string?
[...]

Never mind, the following patch seems to deal with that.

Ben.

--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus