* Re: [remoteproc:for-next 7/12] ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
[not found] <20121006080758.GB29618@localhost>
@ 2012-10-06 9:57 ` Ohad Ben-Cohen
2012-10-22 9:34 ` Ohad Ben-Cohen
0 siblings, 1 reply; 3+ messages in thread
From: Ohad Ben-Cohen @ 2012-10-06 9:57 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Sjur Brændeland, kernel-janitors, linux-kernel
On Sat, Oct 6, 2012 at 10:07 AM, Fengguang Wu <fengguang.wu@intel.com> wrote:
> Hi Sjur,
>
> FYI, kernel build failed on
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/ohad/remoteproc.git for-next
> head: d09f53a735bae43806a77754312a45d3f1198342
> commit: ec4d02d9180f407c41f8310a13b34e473c671fbb [7/12] remoteproc: Add STE modem driver
> config: x86_64-randconfig-s058 (attached as .config)
>
> All error/warnings:
>
> ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
> ERROR: "register_virtio_device" [drivers/remoteproc/remoteproc.ko] undefined!
> ERROR: "unregister_virtio_device" [drivers/remoteproc/remoteproc.ko] undefined!
> ERROR: "vring_new_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
> ERROR: "vring_interrupt" [drivers/remoteproc/remoteproc.ko] undefined!
> ERROR: "vring_transport_features" [drivers/remoteproc/remoteproc.ko] undefined!
Thanks, Fengguang, I've pushed this patch to fix this:
commit ed26d190a3e7718a6b8a4f844e963b408f54ce32
Author: Ohad Ben-Cohen <ohad@wizery.com>
Date: Sat Oct 6 11:35:57 2012 +0200
remoteproc: fix (again) the virtio-related build breakage
Another virtio dependency was overlooked, so add it to fix
the below build breakage. This time for real.
ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
ERROR: "register_virtio_device" [drivers/remoteproc/remoteproc.ko] undefined
ERROR: "unregister_virtio_device" [drivers/remoteproc/remoteproc.ko] undefin
ERROR: "vring_new_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
ERROR: "vring_interrupt" [drivers/remoteproc/remoteproc.ko] undefined!
ERROR: "vring_transport_features" [drivers/remoteproc/remoteproc.ko] undefin
Cc: stable@vger.kernel.org
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index 96ce101..209a4a2 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -7,6 +7,7 @@ config REMOTEPROC
depends on HAS_DMA
select FW_CONFIG
select VIRTIO
+ select VIRTIO_RING
config OMAP_REMOTEPROC
tristate "OMAP remoteproc support"
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [remoteproc:for-next 7/12] ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
2012-10-06 9:57 ` [remoteproc:for-next 7/12] ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined! Ohad Ben-Cohen
@ 2012-10-22 9:34 ` Ohad Ben-Cohen
2012-10-22 9:47 ` Fengguang Wu
0 siblings, 1 reply; 3+ messages in thread
From: Ohad Ben-Cohen @ 2012-10-22 9:34 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Sjur Brændeland, kernel-janitors, linux-kernel
Hello Fengguang,
On Sat, Oct 6, 2012 at 11:57 AM, Ohad Ben-Cohen <ohad@wizery.com> wrote:
> On Sat, Oct 6, 2012 at 10:07 AM, Fengguang Wu <fengguang.wu@intel.com> wrote:
>> ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
>> ERROR: "register_virtio_device" [drivers/remoteproc/remoteproc.ko] undefined!
>> ERROR: "unregister_virtio_device" [drivers/remoteproc/remoteproc.ko] undefined!
>> ERROR: "vring_new_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
>> ERROR: "vring_interrupt" [drivers/remoteproc/remoteproc.ko] undefined!
>> ERROR: "vring_transport_features" [drivers/remoteproc/remoteproc.ko] undefined!
>
> Thanks, Fengguang, I've pushed this patch to fix this:
...
> + select VIRTIO_RING
Do you still see these issues with 3.7-rc2 ?
Rusty eliminated CONFIG_VIRTIO_RING recently, which makes this patch redundant.
I'm dropping this for now, please tell me if you still see any issue.
Thanks,
Ohad.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [remoteproc:for-next 7/12] ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
2012-10-22 9:34 ` Ohad Ben-Cohen
@ 2012-10-22 9:47 ` Fengguang Wu
0 siblings, 0 replies; 3+ messages in thread
From: Fengguang Wu @ 2012-10-22 9:47 UTC (permalink / raw)
To: Ohad Ben-Cohen; +Cc: Sjur Brændeland, kernel-janitors, linux-kernel
On Mon, Oct 22, 2012 at 11:34:24AM +0200, Ohad Ben-Cohen wrote:
> Hello Fengguang,
>
> On Sat, Oct 6, 2012 at 11:57 AM, Ohad Ben-Cohen <ohad@wizery.com> wrote:
> > On Sat, Oct 6, 2012 at 10:07 AM, Fengguang Wu <fengguang.wu@intel.com> wrote:
> >> ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
> >> ERROR: "register_virtio_device" [drivers/remoteproc/remoteproc.ko] undefined!
> >> ERROR: "unregister_virtio_device" [drivers/remoteproc/remoteproc.ko] undefined!
> >> ERROR: "vring_new_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
> >> ERROR: "vring_interrupt" [drivers/remoteproc/remoteproc.ko] undefined!
> >> ERROR: "vring_transport_features" [drivers/remoteproc/remoteproc.ko] undefined!
> >
> > Thanks, Fengguang, I've pushed this patch to fix this:
> ...
> > + select VIRTIO_RING
>
> Do you still see these issues with 3.7-rc2 ?
>
> Rusty eliminated CONFIG_VIRTIO_RING recently, which makes this patch redundant.
>
> I'm dropping this for now, please tell me if you still see any issue.
Ohad, I'm no longer seeing these errors. :)
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-22 9:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20121006080758.GB29618@localhost>
2012-10-06 9:57 ` [remoteproc:for-next 7/12] ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined! Ohad Ben-Cohen
2012-10-22 9:34 ` Ohad Ben-Cohen
2012-10-22 9:47 ` Fengguang Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox