From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: "Yan, Zheng" <zheng.z.yan@intel.com>,
linux-kernel@vger.kernel.org, eranian@google.com
Subject: Re: [PATCH 1/6] perf, x86: Basic Haswell LBR call stack support
Date: Mon, 22 Oct 2012 06:49:35 -0700 [thread overview]
Message-ID: <20121022134935.GH2095@tassilo.jf.intel.com> (raw)
In-Reply-To: <1350902138.2768.86.camel@twins>
On Mon, Oct 22, 2012 at 12:35:38PM +0200, Peter Zijlstra wrote:
> On Mon, 2012-10-22 at 14:11 +0800, Yan, Zheng wrote:
> > --- a/include/uapi/linux/perf_event.h
> > +++ b/include/uapi/linux/perf_event.h
> > @@ -160,8 +160,9 @@ enum perf_branch_sample_type {
> > PERF_SAMPLE_BRANCH_ABORT = 1U << 7, /* transaction aborts */
> > PERF_SAMPLE_BRANCH_INTX = 1U << 8, /* in transaction (flag) */
> > PERF_SAMPLE_BRANCH_NOTX = 1U << 9, /* not in transaction (flag) */
> > + PERF_SAMPLE_BRANCH_CALL_STACK = 1U << 10, /* call stack */
> >
> > - PERF_SAMPLE_BRANCH_MAX = 1U << 10, /* non-ABI */
> > + PERF_SAMPLE_BRANCH_MAX = 1U << 11, /* non-ABI */
> > };
>
> You add an ABI sample type without mentioning it in your changelog.. I
> think I'll stop reading here.
This is a LBR sample type, not a normal sample type.
I think this is only for when LBR mode is enabled in parallel.
Probably doesn't even make sense.
For this feature no ABI changes should be needed because it can
be just reported like any other callgraph with the existing callstack
sample type.
So this could be removed.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-10-22 13:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 6:11 [PATCH 0/6] perf, x86: Haswell LBR call stack support Yan, Zheng
2012-10-22 6:11 ` [PATCH 1/6] perf, x86: Basic " Yan, Zheng
2012-10-22 10:33 ` Peter Zijlstra
2012-10-22 11:23 ` Stephane Eranian
2012-10-23 5:31 ` Yan, Zheng
2012-10-22 13:45 ` Andi Kleen
2012-10-23 5:28 ` Yan, Zheng
2012-10-22 10:35 ` Peter Zijlstra
2012-10-22 13:49 ` Andi Kleen [this message]
2012-10-23 5:41 ` Yan, Zheng
2012-10-23 10:11 ` Peter Zijlstra
2012-10-23 12:09 ` Stephane Eranian
2012-10-23 16:34 ` Andi Kleen
2012-10-22 6:11 ` [PATCH 2/6] perf, x86: Introduce x86 special perf event context Yan, Zheng
2012-10-22 6:11 ` [PATCH 3/6] perf, x86: Save/resotre LBR stack during context switch Yan, Zheng
2012-10-22 6:11 ` [PATCH 4/6] perf, core: Pass perf_sample_data to perf_callchain() Yan, Zheng
2012-10-22 6:11 ` [PATCH 5/6] perf, x86: Use LBR call stack to get user callchain Yan, Zheng
2012-10-22 6:11 ` [PATCH 6/6] perf, x86: Discard zero length call entries in LBR call stack Yan, Zheng
-- strict thread matches above, loose matches on Subject: below --
2012-10-22 5:57 [PATCH 0/6] perf, x86: Haswell LBR call stack support Yan, Zheng
2012-10-22 5:57 ` [PATCH 1/6] perf, x86: Basic " Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022134935.GH2095@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox