From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Stefani Seibold <stefani@seibold.net>,
richard -rw- weinberger <richard.weinberger@gmail.com>,
Wei Yang <weiyang@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove untouched code in kfifo_in
Date: Mon, 22 Oct 2012 16:56:02 -0700 [thread overview]
Message-ID: <20121022165602.41c4953e.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1210190934010.7523@pobox.suse.cz>
On Fri, 19 Oct 2012 09:34:43 +0200 (CEST)
Jiri Kosina <jkosina@suse.cz> wrote:
> On Fri, 19 Oct 2012, Stefani Seibold wrote:
>
> > > > In kfifo_in marco, one piece of code is arounded by if(0). This code in
> > > > introduced by Stefani Seibold <stefani@seibold.net> to suppress a compiler
> > > > warning. This warning is not there with the upgrade of gcc version.
> > > >
> > > > This patch just remove this code.
> > >
> > > Are you sure?
> > > This code fragment looks like a compiler bomb to detect type mismatch to me...
> >
> > Yes, you are great! That was the reason why i made this peace of code.
> > So don't remove it!
>
> As even you, the author of the code, got confused by it for a while,
> adding an explanatory comment seems appropriate.
>
include/linux/typecheck.h?
next prev parent reply other threads:[~2012-10-22 23:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 13:59 [PATCH] remove untouched code in kfifo_in Wei Yang
2012-10-18 22:37 ` richard -rw- weinberger
2012-10-19 5:23 ` Stefani Seibold
2012-10-19 7:34 ` Jiri Kosina
2012-10-22 23:56 ` Andrew Morton [this message]
[not found] ` <508600ba.a7fe440a.4c19.fffff64bSMTPIN_ADDED@mx.google.com>
2012-10-23 19:25 ` richard -rw- weinberger
2012-10-23 19:39 ` Andrew Morton
[not found] ` <5080f0b3.85712b0a.0d0f.ffff9dd2SMTPIN_ADDED@mx.google.com>
2012-10-19 8:14 ` richard -rw- weinberger
[not found] ` <50810e61.688c320a.1baa.6cacSMTPIN_ADDED@mx.google.com>
2012-10-19 8:28 ` richard -rw- weinberger
[not found] <1350463837-30244-1-git-send-email-weiyang@linux.vnet.ibm.com>
2012-10-17 12:37 ` Jiri Kosina
[not found] ` <20121017140136.GA7913@richard.(null)>
2012-10-17 14:05 ` Jiri Kosina
2012-10-17 19:51 ` Stefani Seibold
[not found] ` <20121018015959.GD4511@richard.(null)>
2012-10-18 5:34 ` Stefani Seibold
2012-10-18 7:00 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022165602.41c4953e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=stefani@seibold.net \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox