From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sangho Yi <antiroot@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: CSR: Fixed 41% of exceeding 80 characters problems on drv.c
Date: Mon, 22 Oct 2012 14:03:55 -0700 [thread overview]
Message-ID: <20121022210355.GA23826@kroah.com> (raw)
In-Reply-To: <20121018133638.GP5685@mwanda>
On Thu, Oct 18, 2012 at 04:36:38PM +0300, Dan Carpenter wrote:
> On Mon, Oct 15, 2012 at 12:58:26AM +0900, Sangho Yi wrote:
> > -int buswidth = 0; /* 0 means use default, values 1,4 */
> > -int sdio_clock = 50000; /* kHz */
> > +int buswidth = 0; /* 0 means use default, values 1,4 */
> > +int sdio_clock = 50000; /* kHz */
>
> These are nonsense indenting. :(
I agree. Sangho, please be smart about your cleanups, these two are not
acceptable, so I'm dropping them from my queue.
greg k-h
next prev parent reply other threads:[~2012-10-22 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 15:58 [PATCH 1/2] Staging: CSR: Fixed indentation problems on drv.c (tab mess) Sangho Yi
2012-10-14 15:58 ` [PATCH 2/2] Staging: CSR: Fixed 41% of exceeding 80 characters problems on drv.c Sangho Yi
2012-10-18 13:36 ` Dan Carpenter
2012-10-22 21:03 ` Greg KH [this message]
2012-10-18 13:34 ` [PATCH 1/2] Staging: CSR: Fixed indentation problems on drv.c (tab mess) Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022210355.GA23826@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=antiroot@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox