From: Greg KH <gregkh@linuxfoundation.org>
To: Sangho Yi <antiroot@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: csr: Fixed indentation errors on csr_wifi_vif_utils.h
Date: Mon, 22 Oct 2012 14:07:19 -0700 [thread overview]
Message-ID: <20121022210719.GD23826@kroah.com> (raw)
In-Reply-To: <1350406110-2942-1-git-send-email-antiroot@gmail.com>
On Wed, Oct 17, 2012 at 01:48:29AM +0900, Sangho Yi wrote:
> There were 4 spaces indented lines, so I fixed using tabs.
>
> Signed-off-by: Sangho Yi <antiroot@gmail.com>
> ---
> drivers/staging/csr/csr_wifi_vif_utils.h | 58 ++++++++++++++++--------------
> 1 file changed, 31 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/csr/csr_wifi_vif_utils.h b/drivers/staging/csr/csr_wifi_vif_utils.h
> index 523172d..c997398 100644
> --- a/drivers/staging/csr/csr_wifi_vif_utils.h
> +++ b/drivers/staging/csr/csr_wifi_vif_utils.h
> @@ -1,10 +1,10 @@
> /*****************************************************************************
>
> - (c) Cambridge Silicon Radio Limited 2011
> - All rights reserved and confidential information of CSR
> +(c) Cambridge Silicon Radio Limited 2011
> +All rights reserved and confidential information of CSR
>
> - Refer to LICENSE.txt included with this source for details
> - on the license terms.
> +Refer to LICENSE.txt included with this source for details
> +on the license terms.
>
> *****************************************************************************/
>
> @@ -23,28 +23,29 @@ extern "C" {
>
> /* MACROS *******************************************************************/
>
> -/* Common macros for NME and SME to be used temporarily until SoftMAC changes are made */
> -#define CSR_WIFI_NUM_INTERFACES (u8)0x1
> -#define CSR_WIFI_INTERFACE_IN_USE (u16)0x0
> +/* Common macros for NME and SME to be used temporarily until SoftMAC
> + * changes are made */
> +#define CSR_WIFI_NUM_INTERFACES (u8)0x1
> +#define CSR_WIFI_INTERFACE_IN_USE (u16)0x0
>
> /* This is used at places where interface Id isn't available*/
> -#define CSR_WIFI_INTERFACE_ZERO 0
> -#define CSR_WIFI_INTERFACE_STA 0
> -#define CSR_WIFI_INTERFACE_AMP 0
> +#define CSR_WIFI_INTERFACE_ZERO 0
> +#define CSR_WIFI_INTERFACE_STA 0
> +#define CSR_WIFI_INTERFACE_AMP 0
>
>
> #define CSR_WIFI_VIF_UTILS_UNDEFINED_TAG 0xFFFF
>
> /* Extract the Interface Id from the event */
> #define CsrWifiVifUtilsGetVifTagFromEvent(msg) \
> - ((u16) * ((u16 *) ((u8 *) (msg) + sizeof(CsrWifiFsmEvent))))
> + ((u16) * ((u16 *) ((u8 *) (msg) + sizeof(CsrWifiFsmEvent))))
>
> /* The HPI Vif combines the type and the interface id */
> #define CsrWifiVifUtilsGetVifTagFromHipEvent(msg) \
> - ((msg)->virtualInterfaceIdentifier & 0x00FF)
> + ((msg)->virtualInterfaceIdentifier & 0x00FF)
>
> #define CsrWifiVifUtilsPackHipEventVif(type, interfaceId) \
> - ((u16)((interfaceId) | ((type) << 8)))
> + ((u16)((interfaceId) | ((type) << 8)))
>
>
> /* TYPES DEFINITIONS ********************************************************/
> @@ -55,8 +56,10 @@ extern "C" {
>
> /**
> * @brief
> - * First checks if the mode is supported capability bitmap of the interface.
> - * If this succeeds, then checks if running this mode on this interface is allowed.
> + * First checks if the mode is supported capability bitmap
> + * of the interface.
> + * If this succeeds, then checks if running this mode on this
> + * interface is allowed.
> *
> * @param[in] u8 : interface capability bitmap
> * @param[in] u8* : pointer to the array of current interface modes
> @@ -64,36 +67,37 @@ extern "C" {
> * @param[in] CsrWifiInterfaceMode : mode
> *
> * @return
> - * u8 : returns true if the interface is allowed to operate in the mode otherwise false.
> + * u8 : returns true if the interface is allowed to operate
> + * in the mode otherwise false.
> */
> -extern u8 CsrWifiVifUtilsCheckCompatibility(u8 interfaceCapability,
> - u8 *currentInterfaceModes,
> - u16 interfaceTag,
> - CsrWifiInterfaceMode mode);
> +extern u8 CsrWifiVifUtilsCheckCompatibility(u8 interfaceCapability,
> + u8 *currentInterfaceModes, u16 interfaceTag,
> + CsrWifiInterfaceMode mode);
The first one was almost correct, please indent the parameters back out
to where they line up.
Please redo these two patches and resend.
thanks,
greg k-h
prev parent reply other threads:[~2012-10-22 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 16:48 [PATCH 1/2] staging: csr: Fixed indentation errors on csr_wifi_vif_utils.h Sangho Yi
2012-10-16 16:48 ` [PATCH 2/2] staging: csr: Fixed macro definition style " Sangho Yi
2012-10-22 21:07 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022210719.GD23826@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=antiroot@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox