Re: [PATCH] staging: csr: fix coding style

Greg KH
2012-10-23T02:52:37Z

On Tue, Oct 23, 2012 at 11:41:06AM +0900, SeongJae Park wrote:
> Hello,
>
>
> I think it was my mistake.
>
> CsrThread is enclosed by macro #ifdef __KERNEL__
> and it used by csr_framework_ext.h as CsrThreadHandle type(typedef
> used at csr_framework_ext_types.h).
>
> I think that's why I didn't see build failure.

When building the driver __KERNEL__ is defined :)

> So, I think I should not remove CsrThread.
> If there is anything I missed or wrong, Please let me know.

No, you are right, this can't be removed just yet, so all is good.

If you want to send more patches cleaning stuff up like this one, that
would be great.

thanks,

greg k-h