Re: [PATCH] staging: csr: fix coding style

Lauri Hintsala
2012-10-16T07:13:11Z

Hi,

On 10/15/2012 10:55 AM, SeongJae Park wrote:
> Fix coding style of csr_framework_ext_types.h
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
> drivers/staging/csr/csr_framework_ext_types.h | 33 +++++++++++--------------
> 1 file changed, 15 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/staging/csr/csr_framework_ext_types.h b/drivers/staging/csr/csr_framework_ext_types.h
> index 57194ee..7e9cf8e 100644
> --- a/drivers/staging/csr/csr_framework_ext_types.h
> +++ b/drivers/staging/csr/csr_framework_ext_types.h
> @@ -2,11 +2,11 @@

...

> @@ -24,17 +24,15 @@ extern "C" {
>
> #ifdef __KERNEL__
>
> -struct CsrThread
> -{
> - struct task_struct *thread_task;
> - char name[16];
> +struct CsrThreadi {

I think this extra i letter at the end of CsrThreadi string is typo. Did
you try to compile the driver with your changes?

Best regards,
Lauri Hintsala

> + struct task_struct *thread_task;
> + char name[16];

...