* [PATCH 2/4] backlight: lms283gf05: add missing const
@ 2012-10-23 4:19 Jingoo Han
2012-10-23 7:34 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2012-10-23 4:19 UTC (permalink / raw)
To: 'Andrew Morton', 'LKML'
Cc: 'Richard Purdie', 'Marek Vasut',
'Jingoo Han'
Add 'const' to static array that was missing it in its
definition.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
drivers/video/backlight/lms283gf05.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/lms283gf05.c b/drivers/video/backlight/lms283gf05.c
index ea43f22..151f0da 100644
--- a/drivers/video/backlight/lms283gf05.c
+++ b/drivers/video/backlight/lms283gf05.c
@@ -31,7 +31,7 @@ struct lms283gf05_seq {
};
/* Magic sequences supplied by manufacturer, for details refer to datasheet */
-static struct lms283gf05_seq disp_initseq[] = {
+static const struct lms283gf05_seq disp_initseq[] = {
/* REG, VALUE, DELAY */
{ 0x07, 0x0000, 0 },
{ 0x13, 0x0000, 10 },
@@ -78,7 +78,7 @@ static struct lms283gf05_seq disp_initseq[] = {
{ 0x22, 0x0000, 0 }
};
-static struct lms283gf05_seq disp_pdwnseq[] = {
+static const struct lms283gf05_seq disp_pdwnseq[] = {
{ 0x07, 0x0016, 30 },
{ 0x07, 0x0004, 0 },
@@ -104,7 +104,7 @@ static void lms283gf05_reset(unsigned long gpio, bool inverted)
}
static void lms283gf05_toggle(struct spi_device *spi,
- struct lms283gf05_seq *seq, int sz)
+ const struct lms283gf05_seq *seq, int sz)
{
char buf[3];
int i;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] backlight: lms283gf05: add missing const
2012-10-23 4:19 [PATCH 2/4] backlight: lms283gf05: add missing const Jingoo Han
@ 2012-10-23 7:34 ` Marek Vasut
2012-10-23 7:43 ` Jingoo Han
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2012-10-23 7:34 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', 'LKML', 'Richard Purdie'
Dear Jingoo Han,
> Add 'const' to static array that was missing it in its
> definition.
Did you get compiler warning? Still, this is a good pick
Acked-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> ---
[...]
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] backlight: lms283gf05: add missing const
2012-10-23 7:34 ` Marek Vasut
@ 2012-10-23 7:43 ` Jingoo Han
0 siblings, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2012-10-23 7:43 UTC (permalink / raw)
To: 'Marek Vasut'
Cc: 'Andrew Morton', 'LKML', 'Richard Purdie',
'Jingoo Han'
On Tuesday, October 23, 2012 4:35 PM Marek Vasut wrote
>
> Dear Jingoo Han,
>
> > Add 'const' to static array that was missing it in its
> > definition.
>
> Did you get compiler warning? Still, this is a good pick
No, I didn't get compiler warning. :)
Thank you for your reply.
>
> Acked-by: Marek Vasut <marex@denx.de>
>
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > Cc: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Richard Purdie <rpurdie@rpsys.net>
> > ---
> [...]
>
> Best regards,
> Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-23 7:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-23 4:19 [PATCH 2/4] backlight: lms283gf05: add missing const Jingoo Han
2012-10-23 7:34 ` Marek Vasut
2012-10-23 7:43 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox