From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757086Ab2JWNgs (ORCPT ); Tue, 23 Oct 2012 09:36:48 -0400 Received: from one.firstfloor.org ([213.235.205.2]:59847 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754626Ab2JWNgq (ORCPT ); Tue, 23 Oct 2012 09:36:46 -0400 Date: Tue, 23 Oct 2012 15:36:45 +0200 From: Andi Kleen To: Andi Kleen Cc: Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com, eranian@google.com, Andi Kleen , avi@redhat.com, Gleb Natapov Subject: Re: [PATCH 06/34] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation v2 Message-ID: <20121023133645.GB16230@one.firstfloor.org> References: <1350602382-12771-1-git-send-email-andi@firstfloor.org> <1350602382-12771-7-git-send-email-andi@firstfloor.org> <1350995765.13456.15.camel@twins> <20121023133527.GA16230@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121023133527.GA16230@one.firstfloor.org> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 23, 2012 at 03:35:27PM +0200, Andi Kleen wrote: > > So I forgot how all this worked, but will the KVM emulation not pass > > this straight down to the hardware? > > Pass down to perf. > > > > > Don't we have a problem where we're emulating arch perfmon v1 on AMD > > hardware? On AMD hardware those bits do have meaning. > > Ah they do? I wasn't aware. I can add a cpuid check for Intel I suppose. Ah now I remember: I wrote it for the original qualifiers which would have worked fine for AMD too. It just broke with the raw events you asked for. Ok will do the cpuid check to work around this problem. -Andi -- ak@linux.intel.com -- Speaking for myself only.