public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: "Yan, Zheng" <zheng.z.yan@intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org, eranian@google.com
Subject: Re: [PATCH 1/6] perf, x86: Basic Haswell LBR call stack support
Date: Tue, 23 Oct 2012 09:34:43 -0700	[thread overview]
Message-ID: <20121023163443.GS2095@tassilo.jf.intel.com> (raw)
In-Reply-To: <50862E02.6020002@intel.com>

> > You add an ABI sample type without mentioning it in your changelog.. I
> > think I'll stop reading here.
> > 
> Ok, I will add the ABI change to the change log. Do you think we should hide this
> branch sample type from user?

Yes I would hide it. No need to expose, except as a callstack.

-Andi


-- 
ak@linux.intel.com -- Speaking for myself only

  parent reply	other threads:[~2012-10-23 16:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22  6:11 [PATCH 0/6] perf, x86: Haswell LBR call stack support Yan, Zheng
2012-10-22  6:11 ` [PATCH 1/6] perf, x86: Basic " Yan, Zheng
2012-10-22 10:33   ` Peter Zijlstra
2012-10-22 11:23     ` Stephane Eranian
2012-10-23  5:31       ` Yan, Zheng
2012-10-22 13:45     ` Andi Kleen
2012-10-23  5:28     ` Yan, Zheng
2012-10-22 10:35   ` Peter Zijlstra
2012-10-22 13:49     ` Andi Kleen
2012-10-23  5:41     ` Yan, Zheng
2012-10-23 10:11       ` Peter Zijlstra
2012-10-23 12:09       ` Stephane Eranian
2012-10-23 16:34       ` Andi Kleen [this message]
2012-10-22  6:11 ` [PATCH 2/6] perf, x86: Introduce x86 special perf event context Yan, Zheng
2012-10-22  6:11 ` [PATCH 3/6] perf, x86: Save/resotre LBR stack during context switch Yan, Zheng
2012-10-22  6:11 ` [PATCH 4/6] perf, core: Pass perf_sample_data to perf_callchain() Yan, Zheng
2012-10-22  6:11 ` [PATCH 5/6] perf, x86: Use LBR call stack to get user callchain Yan, Zheng
2012-10-22  6:11 ` [PATCH 6/6] perf, x86: Discard zero length call entries in LBR call stack Yan, Zheng
  -- strict thread matches above, loose matches on Subject: below --
2012-10-22  5:57 [PATCH 0/6] perf, x86: Haswell LBR call stack support Yan, Zheng
2012-10-22  5:57 ` [PATCH 1/6] perf, x86: Basic " Yan, Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121023163443.GS2095@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zheng.z.yan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox