* [bug] perf_event_intel_uncore.c build warnings on allnoconfig
@ 2012-10-24 7:29 Ingo Molnar
2012-10-24 17:24 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2012-10-24 7:29 UTC (permalink / raw)
To: Yan, Zheng; +Cc: Peter Zijlstra, linux-kernel
FYI, on a 'make allnoconfig' x86_64 kernel I get a stream of
warnings:
arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ‘snbep_uncore_pci_disable_box’:
arch/x86/kernel/cpu/perf_event_intel_uncore.c:124:9: warning: ‘config’ is used uninitialized in this function [-Wuninitialized]
arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ‘snbep_uncore_pci_enable_box’:
arch/x86/kernel/cpu/perf_event_intel_uncore.c:135:9: warning: ‘config’ is used uninitialized in this function [-Wuninitialized]
arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ‘snbep_uncore_pci_read_counter’:
arch/x86/kernel/cpu/perf_event_intel_uncore.c:164:2: warning: ‘count’ is used uninitialized in this function [-Wuninitialized]
Please fix this - if pci_read_config_dword() returns an error it
should be handled - that will fix these warnings as well.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [bug] perf_event_intel_uncore.c build warnings on allnoconfig
2012-10-24 7:29 [bug] perf_event_intel_uncore.c build warnings on allnoconfig Ingo Molnar
@ 2012-10-24 17:24 ` Andi Kleen
2012-10-24 20:03 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2012-10-24 17:24 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Zheng, Peter Zijlstra, linux-kernel
Ingo Molnar <mingo@kernel.org> writes:
> FYI, on a 'make allnoconfig' x86_64 kernel I get a stream of
> warnings:
>
> arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ‘snbep_uncore_pci_disable_box’:
> arch/x86/kernel/cpu/perf_event_intel_uncore.c:124:9: warning: ‘config’ is used uninitialized in this function [-Wuninitialized]
> arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ‘snbep_uncore_pci_enable_box’:
> arch/x86/kernel/cpu/perf_event_intel_uncore.c:135:9: warning: ‘config’ is used uninitialized in this function [-Wuninitialized]
> arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ‘snbep_uncore_pci_read_counter’:
> arch/x86/kernel/cpu/perf_event_intel_uncore.c:164:2: warning: ‘count’ is used uninitialized in this function [-Wuninitialized]
>
> Please fix this - if pci_read_config_dword() returns an error it
> should be handled - that will fix these warnings as well.
Can it even return an error on x86? I don't know of any existing
mechanism for this, short of a machine check.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [bug] perf_event_intel_uncore.c build warnings on allnoconfig
2012-10-24 17:24 ` Andi Kleen
@ 2012-10-24 20:03 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2012-10-24 20:03 UTC (permalink / raw)
To: Andi Kleen; +Cc: Zheng, Peter Zijlstra, linux-kernel
* Andi Kleen <andi@firstfloor.org> wrote:
> Ingo Molnar <mingo@kernel.org> writes:
>
> > FYI, on a 'make allnoconfig' x86_64 kernel I get a stream of
> > warnings:
> >
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ???snbep_uncore_pci_disable_box???:
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c:124:9: warning: ???config??? is used uninitialized in this function [-Wuninitialized]
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ???snbep_uncore_pci_enable_box???:
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c:135:9: warning: ???config??? is used uninitialized in this function [-Wuninitialized]
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ???snbep_uncore_pci_read_counter???:
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c:164:2: warning: ???count??? is used uninitialized in this function [-Wuninitialized]
> >
> > Please fix this - if pci_read_config_dword() returns an error it
> > should be handled - that will fix these warnings as well.
>
> Can it even return an error on x86? I don't know of any
> existing mechanism for this, short of a machine check.
It will return an error on !CONFIG_PCI at least.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-24 20:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-24 7:29 [bug] perf_event_intel_uncore.c build warnings on allnoconfig Ingo Molnar
2012-10-24 17:24 ` Andi Kleen
2012-10-24 20:03 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).