From: Ingo Molnar <mingo@kernel.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Michel Lespinasse <walken@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] rbtree: include linux/compiler.h for definition of __always_inline
Date: Wed, 24 Oct 2012 09:45:13 +0200 [thread overview]
Message-ID: <20121024074513.GB25872@gmail.com> (raw)
In-Reply-To: <20121023092927.GB19167@mudshark.cambridge.arm.com>
* Will Deacon <will.deacon@arm.com> wrote:
> On Mon, Oct 22, 2012 at 10:56:21PM +0100, Michel Lespinasse wrote:
> > On Mon, Oct 22, 2012 at 10:01 AM, Will Deacon <will.deacon@arm.com> wrote:
> > > rb_erase_augmented is a static function annotated with __always_inline.
> > > This causes a compile failure when attempting to use the rbtree
> > > implementation as a library (e.g. kvm tool):
> > >
> > > rbtree_augmented.h:125:24: error: expected ???=???, ???,???, ???;???, ???asm??? or ???__attribute__??? before ???void???
> > >
> > > This patch includes linux/compiler.h in rbtree_augmented.h so that the
> > > __always_inline macro is resolved correctly.
> > >
> > > Cc: Pekka Enberg <penberg@kernel.org>
> > > Cc: Michel Lespinasse <walken@google.com>
> > > Cc: Ingo Molnar <mingo@elte.hu>
> > > Signed-off-by: Will Deacon <will.deacon@arm.com>
> >
> > Just curious - what are you going to implement with augmented rbtrees
> > in kvm tool ?
> >
> > If the basic rbtree or the interval tree implementations are
> > sufficient for your usage, you should try using that (in which case
> > you won't need this header fix).
>
> kvm tool uses interval rbtrees for things like keeping track
> of virtual devices, although it looks like Ingo implemented
> the augment callbacks while moving to -rc1.
Yeah, latest kvmtool uses the modern augmented-rbtree facility
of the kernel.
Thanks,
Ingo
prev parent reply other threads:[~2012-10-24 7:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 17:01 [PATCH] rbtree: include linux/compiler.h for definition of __always_inline Will Deacon
2012-10-22 21:56 ` Michel Lespinasse
2012-10-23 9:29 ` Will Deacon
2012-10-24 7:45 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024074513.GB25872@gmail.com \
--to=mingo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=walken@google.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).