From: Jesper Nilsson <jesper.nilsson@axis.com>
To: David Howells <dhowells@redhat.com>
Cc: starvik@axis.com, linux-cris-kernel@axis.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UAPI: Fix up empty files in arch/cris/
Date: Wed, 24 Oct 2012 10:07:22 +0200 [thread overview]
Message-ID: <20121024080721.GB29793@axis.com> (raw)
In-Reply-To: <20121022121844.14852.49121.stgit@warthog.procyon.org.uk>
On Mon, Oct 22, 2012 at 01:18:44PM +0100, David Howells wrote:
> Fix up three empty files in arch/cris/ by sticking placeholder comments in
> there to prevent the patch program from deleting them.
>
> I decided not to delete the arch-v*/Kbuild files as it's possibly someone might
> want to use them for genhdr-y lines in the future, but they could be deleted
> and the pointer lines removed from asm/Kbuild. The uapi/arch-v*/Kbuild files
> ought to be uneffected by such a change.
>
> asm/swab.h didn't have anything outside of __KERNEL__ so nothing appeared in
> uapi/asm/swab.h. The latter, however, is exported by Kbuild.asm.
>
> This needs to be applied after the CRIS UAPI disintegration patch.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Thanks, I've rewritten the comments to match the canonical name of the
architectures, and applied the following patch to the CRIS-tree
(with the same comment as above).
---
arch/cris/include/arch-v10/arch/Kbuild | 1 +
arch/cris/include/arch-v32/arch/Kbuild | 1 +
arch/cris/include/uapi/asm/swab.h | 3 +++
3 files changed, 5 insertions(+)
diff --git a/arch/cris/include/arch-v10/arch/Kbuild b/arch/cris/include/arch-v10/arch/Kbuild
index e69de29..1f0fc7a 100644
--- a/arch/cris/include/arch-v10/arch/Kbuild
+++ b/arch/cris/include/arch-v10/arch/Kbuild
@@ -0,0 +1 @@
+# CRISv10 arch
diff --git a/arch/cris/include/arch-v32/arch/Kbuild b/arch/cris/include/arch-v32/arch/Kbuild
index e69de29..2fd65c7 100644
--- a/arch/cris/include/arch-v32/arch/Kbuild
+++ b/arch/cris/include/arch-v32/arch/Kbuild
@@ -0,0 +1 @@
+# CRISv32 arch
diff --git a/arch/cris/include/uapi/asm/swab.h b/arch/cris/include/uapi/asm/swab.h
index e69de29..4adf1e9 100644
--- a/arch/cris/include/uapi/asm/swab.h
+++ b/arch/cris/include/uapi/asm/swab.h
@@ -0,0 +1,3 @@
+/*
+ * CRIS byte swapping.
+ */
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
prev parent reply other threads:[~2012-10-24 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 12:18 [PATCH] UAPI: Fix up empty files in arch/cris/ David Howells
2012-10-24 8:07 ` Jesper Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024080721.GB29793@axis.com \
--to=jesper.nilsson@axis.com \
--cc=dhowells@redhat.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).