From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: akpm@linux-foundation.org, a.p.zijlstra@chello.nl,
xemul@parallels.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: + procfs-add-vmflags-field-in-smaps-output-v3-fix-2.patch added to -mm tree
Date: Wed, 24 Oct 2012 14:39:41 +0400 [thread overview]
Message-ID: <20121024103941.GG30983@moon> (raw)
In-Reply-To: <20121024212620.da7147354d523151c97de962@canb.auug.org.au>
On Wed, Oct 24, 2012 at 09:26:20PM +1100, Stephen Rothwell wrote:
> > Hi Stephen, could you please elaborate, which bad usage hiding could be there?
>
> I though it might suppress a warning if someone added an entry with a >2
> character string, but testing shows that it does not, so that is OK.
> There is still no need for the cast, though, or the second set of
> braces. The C standard allows fixed length char arrays to be initialised
> by string constants and discards the trailing NUL if necessary.
OK, fair enough. I'll post a new patch with all concerns fixed in one
pass. Thanks all for comments!
prev parent reply other threads:[~2012-10-24 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121023220300.1185C200057@hpza10.eem.corp.google.com>
2012-10-24 8:45 ` + procfs-add-vmflags-field-in-smaps-output-v3-fix-2.patch added to -mm tree Cyrill Gorcunov
2012-10-24 9:24 ` Peter Zijlstra
2012-10-24 9:49 ` Cyrill Gorcunov
2012-10-24 9:47 ` Stephen Rothwell
2012-10-24 9:59 ` Cyrill Gorcunov
2012-10-24 10:26 ` Stephen Rothwell
2012-10-24 10:39 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024103941.GG30983@moon \
--to=gorcunov@openvz.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).