From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758477Ab2JXML5 (ORCPT ); Wed, 24 Oct 2012 08:11:57 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:62466 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755194Ab2JXML4 (ORCPT ); Wed, 24 Oct 2012 08:11:56 -0400 Date: Wed, 24 Oct 2012 10:11:49 -0200 From: Gustavo Padovan To: Jeff Cook Cc: marcel@holtmann.org, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17b5] Message-ID: <20121024121149.GE13884@joana> Mail-Followup-To: Gustavo Padovan , Jeff Cook , marcel@holtmann.org, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org References: <5087B517.9090703@deserettechnology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5087B517.9090703@deserettechnology.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jeff, * Jeff Cook [2012-10-24 03:29:59 -0600]: > Hello all, > > Please see included patch. First-time submitter so let me know if I did > something wrong. Your patch is good, but you need to improve the way you submit it. We recommend using 'git send-email' like this: $ git send-email HEAD~1..HEAD For sending the patch on the top of tree. You can also do combined use of 'git format-patch' and 'git send-email' in case you want to add some message or to your patch like the first-time submitter message you did here and these messages needs to be added... > > Thanks, > Jeff > -------------------- > > Vendor-specific ID for BCM20702A0. > Support for bluetooth over Asus Wi-Fi GO!, included with Asus P8Z77-V > Deluxe. > > T: Bus=07 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=0b05 ProdID=17b5 Rev=01.12 > S: Manufacturer=Broadcom Corp > S: Product=BCM20702A0 > S: SerialNumber=94DBC98AC113 > C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA > I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) > --- ... after these 3 dashes lines so they don't go the final commit when I apply your patch. Gustavo