From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Pavel Emelyanov <xemul@parallels.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH -mm] procfs: add VmFlags field in smaps output v3
Date: Wed, 24 Oct 2012 16:56:40 +0400 [thread overview]
Message-ID: <20121024125640.GR30983@moon> (raw)
In-Reply-To: <20121024234714.03b516f6fcb32eb5a27eed1b@canb.auug.org.au>
On Wed, Oct 24, 2012 at 11:47:14PM +1100, Stephen Rothwell wrote:
> Hi Cyrill,
>
> On Wed, 24 Oct 2012 16:27:30 +0400 Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> >
> > +static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)
> > +{
> > + /*
> > + * Don't forget to update Documentation/ on changes.
> > + */
> > + static const char mnemonics[BITS_PER_LONG][2] = {
> > + /*
> > + * In case if we meet a flag we don't know about.
> > + */
> > + [0 ... (BITS_PER_LONG-1)] = { "??" },
>
> Sorry to be picky, but the braces above are unnecessary,
Thanks, Stephen! I'm deferring update for a while, ok? If there will
be no more comments i'll drop the braces a bit later.
next prev parent reply other threads:[~2012-10-24 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 12:27 [PATCH -mm] procfs: add VmFlags field in smaps output v3 Cyrill Gorcunov
2012-10-24 12:47 ` Stephen Rothwell
2012-10-24 12:56 ` Cyrill Gorcunov [this message]
2012-10-24 20:36 ` Andrew Morton
2012-10-24 20:41 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024125640.GR30983@moon \
--to=gorcunov@openvz.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox