From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
Brad Spengler <spender@grsecurity.net>,
PaX Team <pageexec@freemail.hu>
Subject: Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding
Date: Wed, 24 Oct 2012 14:02:27 -0700 [thread overview]
Message-ID: <20121024140227.299041a9.akpm@linux-foundation.org> (raw)
In-Reply-To: <20121024205756.GA12419@www.outflux.net>
On Wed, 24 Oct 2012 13:57:56 -0700
Kees Cook <keescook@chromium.org> wrote:
> Fix possible overflow of the buffer used for expanding environment
> variables when building file list.
>
> $ cat usr/crash.list
> file foo ${BIG}${BIG}${BIG}${BIG}${BIG}${BIG} 0755 0 0
> $ BIG=$(perl -e 'print "A" x 4096;') ./usr/gen_init_cpio usr/crash.list
> *** buffer overflow detected ***: ./usr/gen_init_cpio terminated
>
> This also replaces the space-indenting with tabs.
>
> Patch based on existing fix extracted from grsecurity.
>
> ...
>
> Cc: stable@vger.kernel.org
Why did you feel we need to backport this to -stable?
next prev parent reply other threads:[~2012-10-24 21:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 20:57 [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding Kees Cook
2012-10-24 21:02 ` Andrew Morton [this message]
2012-10-24 21:33 ` Kees Cook
2012-10-24 21:44 ` Andrew Morton
2012-10-24 21:53 ` Kees Cook
2012-10-24 21:56 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024140227.299041a9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pageexec@freemail.hu \
--cc=spender@grsecurity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox