From: Greg KH <gregkh@linuxfoundation.org>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
hpa@zytor.com, xemul@parallels.com, jslaby@suse.cz
Subject: Re: [patch 1/3] tty: pty - Move TIOCPKT handling into pty.c
Date: Wed, 24 Oct 2012 11:27:47 -0700 [thread overview]
Message-ID: <20121024182747.GA2614@kroah.com> (raw)
In-Reply-To: <20120927211121.651422569@openvz.org>
On Fri, Sep 28, 2012 at 01:10:33AM +0400, Cyrill Gorcunov wrote:
> Since this ioctl is for pty devices only move it to pty.c.
>
> v2:
> - drop PTY_TYPE_MASTER test since it's master peer
> ioctl anyway (by jslaby@)
This patch adds the compiler warning:
drivers/tty/tty_ioctl.c: In function ‘n_tty_ioctl_helper’:
drivers/tty/tty_ioctl.c:1121:16: warning: unused variable ‘flags’ [-Wunused-variable]
Care to fix it up and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2012-10-24 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 21:10 [patch 0/3] ttys flags, updated Cyrill Gorcunov
2012-09-27 21:10 ` [patch 1/3] tty: pty - Move TIOCPKT handling into pty.c Cyrill Gorcunov
2012-10-16 8:33 ` Cyrill Gorcunov
2012-10-16 8:58 ` Alan Cox
2012-10-16 8:57 ` Cyrill Gorcunov
2012-10-24 18:27 ` Greg KH [this message]
2012-09-27 21:10 ` [patch 2/3] tty, ioctls -- Add new ioctl definitions for tty flags fetching Cyrill Gorcunov
2012-10-24 18:28 ` Greg KH
2012-10-24 18:35 ` Cyrill Gorcunov
2012-09-27 21:10 ` [patch 3/3] tty: Add get- ioctls to fetch tty status v3 Cyrill Gorcunov
-- strict thread matches above, loose matches on Subject: below --
2012-10-16 9:46 [patch 0/3] TTY flags fetching gorcunov
2012-10-16 9:46 ` [patch 1/3] tty: pty - Move TIOCPKT handling into pty.c gorcunov
2012-10-24 19:43 [PATCH 0/3] TTY -- Add get- ioctls to fetch tty status v3 Cyrill Gorcunov
2012-10-24 19:43 ` [PATCH 1/3] tty: pty - Move TIOCPKT handling into pty.c Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024182747.GA2614@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).