From: Ingo Molnar <mingo@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Zheng <zheng.z.yan@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org
Subject: Re: [bug] perf_event_intel_uncore.c build warnings on allnoconfig
Date: Wed, 24 Oct 2012 22:03:59 +0200 [thread overview]
Message-ID: <20121024200359.GB25643@gmail.com> (raw)
In-Reply-To: <m2y5ivrdeu.fsf@firstfloor.org>
* Andi Kleen <andi@firstfloor.org> wrote:
> Ingo Molnar <mingo@kernel.org> writes:
>
> > FYI, on a 'make allnoconfig' x86_64 kernel I get a stream of
> > warnings:
> >
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ???snbep_uncore_pci_disable_box???:
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c:124:9: warning: ???config??? is used uninitialized in this function [-Wuninitialized]
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ???snbep_uncore_pci_enable_box???:
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c:135:9: warning: ???config??? is used uninitialized in this function [-Wuninitialized]
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ???snbep_uncore_pci_read_counter???:
> > arch/x86/kernel/cpu/perf_event_intel_uncore.c:164:2: warning: ???count??? is used uninitialized in this function [-Wuninitialized]
> >
> > Please fix this - if pci_read_config_dword() returns an error it
> > should be handled - that will fix these warnings as well.
>
> Can it even return an error on x86? I don't know of any
> existing mechanism for this, short of a machine check.
It will return an error on !CONFIG_PCI at least.
Thanks,
Ingo
prev parent reply other threads:[~2012-10-24 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 7:29 [bug] perf_event_intel_uncore.c build warnings on allnoconfig Ingo Molnar
2012-10-24 17:24 ` Andi Kleen
2012-10-24 20:03 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024200359.GB25643@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).