[PATCH RESEND] max17042: missing assignment

[PATCH RESEND] max17042: missing assignment

[Alan Cox]

From: Alan Cox <alan@linux.intel.com>

The second error check is unreachable because the lock function
isn't assigned to ret

Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 drivers/power/max17042_battery.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
index 74abc6c..73b432d 100644
--- a/drivers/power/max17042_battery.c
+++ b/drivers/power/max17042_battery.c
@@ -572,7 +572,7 @@ static int max17042_init_chip(struct max17042_chip *chip)
 			__func__);
 		return -EIO;
 	}
-	max17042_verify_model_lock(chip);
+	ret = max17042_verify_model_lock(chip);
 	if (ret) {
 		dev_err(&chip->client->dev, "%s lock verify failed\n",
 			__func__);

RE: [PATCH RESEND] max17042: missing assignment

[Pallala, Ramakrishna]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 984 bytes --]


Thanks Alan.

> The second error check is unreachable because the lock function isn't assigned
> to ret
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>
Acked-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>

> ---
> 
>  drivers/power/max17042_battery.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/max17042_battery.c
> b/drivers/power/max17042_battery.c
> index 74abc6c..73b432d 100644
> --- a/drivers/power/max17042_battery.c
> +++ b/drivers/power/max17042_battery.c
> @@ -572,7 +572,7 @@ static int max17042_init_chip(struct max17042_chip
> *chip)
>  			__func__);
>  		return -EIO;
>  	}
> -	max17042_verify_model_lock(chip);
> +	ret = max17042_verify_model_lock(chip);
>  	if (ret) {
>  		dev_err(&chip->client->dev, "%s lock verify failed\n",
>  			__func__);

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH RESEND] max17042: missing assignment

[Anton Vorontsov]

On Thu, Oct 25, 2012 at 02:28:03PM +0000, Pallala, Ramakrishna wrote:
> 
> Thanks Alan.
> 
> > The second error check is unreachable because the lock function isn't assigned
> > to ret
> > 
> > Signed-off-by: Alan Cox <alan@linux.intel.com>
> Acked-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>

For some reason I don't have the original patch in my mailbox. I wonder if
I have not been Cc'ed on this one or it got lost...

Anyway, I reconstructed it by hand and applied, thanks a lot!

Anton.

> > ---
> > 
> >  drivers/power/max17042_battery.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/power/max17042_battery.c
> > b/drivers/power/max17042_battery.c
> > index 74abc6c..73b432d 100644
> > --- a/drivers/power/max17042_battery.c
> > +++ b/drivers/power/max17042_battery.c
> > @@ -572,7 +572,7 @@ static int max17042_init_chip(struct max17042_chip
> > *chip)
> >  			__func__);
> >  		return -EIO;
> >  	}
> > -	max17042_verify_model_lock(chip);
> > +	ret = max17042_verify_model_lock(chip);
> >  	if (ret) {
> >  		dev_err(&chip->client->dev, "%s lock verify failed\n",
> >  			__func__);
>