public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] irq: tsk->comm is an array
Date: Thu, 25 Oct 2012 16:01:01 +0100	[thread overview]
Message-ID: <20121025150056.17719.94347.stgit@localhost.localdomain> (raw)

From: Alan Cox <alan@linux.intel.com>

More relevantly what about termination and locks ?

Anyway the array check is useless so remove it.

Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 kernel/irq/manage.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 4c69326..ea39714 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -792,8 +792,9 @@ static void irq_thread_dtor(struct callback_head *unused)
 
 	action = kthread_data(tsk);
 
+	/* FIXME: locking */
 	pr_err("exiting task \"%s\" (%d) is an active IRQ thread (irq %d)\n",
-	       tsk->comm ? tsk->comm : "", tsk->pid, action->irq);
+	       tsk->comm, tsk->pid, action->irq);
 
 
 	desc = irq_to_desc(action->irq);


             reply	other threads:[~2012-10-25 14:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-25 15:01 Alan Cox [this message]
2012-10-25 20:04 ` [PATCH] irq: tsk->comm is an array David Rientjes
  -- strict thread matches above, loose matches on Subject: below --
2012-11-06 14:28 Alan Cox
2012-11-06 19:26 ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121025150056.17719.94347.stgit@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox