Re: [PATCH 04/10] VMCI: device driver implementaton.

Greg KH
2012-10-25T19:28:55Z

On Mon, Oct 15, 2012 at 05:28:47PM -0700, George Zhang wrote:
> +/*
> + * vmci_device_get() - Checks for VMCI device.
> + * @api_version: The API version to use
> + * @device_shutdown_cb: Callback used when shutdown happens (Unused)
> + * @user_data: Data to be passed to the callback (Unused)
> + * @device_registration: A device registration handle. (Unused)
> + *
> + * Verifies that a valid VMCI device is present, and indicates
> + * the callers intention to use the device until it calls
> + * vmci_device_release().
> + */
> +bool vmci_device_get(u32 *api_version,
> + vmci_device_shutdown_fn *device_shutdown_cb,
> + void *user_data, void **device_registration)
> +{
> + if (*api_version > VMCI_KERNEL_API_VERSION) {
> + *api_version = VMCI_KERNEL_API_VERSION;
> + return false;
> + }
> +
> + return drv_device_enabled();
> +}
> +EXPORT_SYMBOL(vmci_device_get);

EXPORT_SYMBOL_GPL() for this, and all other exports?

And it seems that you have a bunch of "unused" parameters for this, and
other public functions. Please just remove them entirely, otherwise it
just confuses reviewers, and anyone who wants to write code to interface
with the code. You can always add parameters at a later point in time
if you find that you really need them.

thanks,

greg k-h