From: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3 v2] firmware: Add /proc/firmware_path entry to list the firmware paths
Date: Fri, 26 Oct 2012 11:07:31 +0100 [thread overview]
Message-ID: <20121026100731.GA10468@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121025184833.GA22114@kroah.com>
On Thu, Oct 25, 2012 at 11:48:33AM -0700, Greg Kroah-Hartman wrote:
> On Tue, Oct 23, 2012 at 01:52:55PM +0100, Dimitris Papastamos wrote:
> > This patch provides the aforementioned procfs file that lists
> > the default firmware paths that are used during firmware lookup.
> >
> > The file contains a white space separated list of paths.
>
> Paths can have whitespaces :(
>
> How about using the "universal" path seperator of ':' that shells are
> used to using? Yeah, it gets messy if you have a ':' in a path, but
> from what I can tell, only the openSUSE build system does looney things
> like that.
Sure I can do that, however, could you comment on Ming's comments? Is
this patchset something we find useful at the moment as regards listing
and/or updating the firmware path list.
> > There will be another patch on top of this that adds the functionality
> > to modify the paths at runtime.
>
> Did I miss that patch somewhere?
That patch is here:
http://opensource.wolfsonmicro.com/~dp/patches/firmware/0004-firmware-Add-write-support-to-proc-fw_path.patch
However I've not rebased that patch on top of linux-next and I did not
send it for review as it seems that it may be a more sensible solution
to pass this as a kernel parameter.
Let me know what you think and I'll squeeze some time this weekend
to look at this.
Thanks,
Dimitris
next prev parent reply other threads:[~2012-10-26 10:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 12:52 [PATCH 0/3 v2] Expose firmware paths via procfs Dimitris Papastamos
2012-10-23 12:52 ` [PATCH 1/3 v2] firmware: Convert firmware path setup from an array to a list Dimitris Papastamos
2012-10-23 13:08 ` Ming Lei
2012-10-23 13:29 ` Dimitris Papastamos
2012-10-23 13:37 ` Ming Lei
2012-10-23 13:44 ` Dimitris Papastamos
2012-10-23 14:37 ` Ming Lei
2012-10-23 12:52 ` [PATCH 2/3 v2] firmware: Add /proc/firmware_path entry to list the firmware paths Dimitris Papastamos
2012-10-25 18:48 ` Greg Kroah-Hartman
2012-10-26 10:07 ` Dimitris Papastamos [this message]
2012-10-26 23:56 ` Greg Kroah-Hartman
2012-10-23 12:52 ` [PATCH 3/3 v2] firmware: Factor out code to add paths to the firmware path list Dimitris Papastamos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026100731.GA10468@opensource.wolfsonmicro.com \
--to=dp@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox