linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: yan yan <clouds.yan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] debugfs: pass NULL as the last parameter of debugfs_print_regs32()
Date: Fri, 26 Oct 2012 11:48:33 -0700	[thread overview]
Message-ID: <20121026184833.GA17121@kroah.com> (raw)
In-Reply-To: <CAH+=+MG3f+OsH5z-EhGM2o6eiPrugkStV2dQD+fbCWU=omZnmA@mail.gmail.com>

On Sat, Oct 27, 2012 at 02:34:02AM +0800, yan yan wrote:
> 2012/10/27 Greg KH <gregkh@linuxfoundation.org>:
> > On Sat, Oct 27, 2012 at 01:55:42AM +0800, Yan Hong wrote:
> >> Pass NULL instead of empty string to debugfs_print_regs32() when
> >> prefix is not used, according to the intention of the code.
> >
> > Is this solving a problem?  Is it wrong as-is?  Is it causing an issue
> > today?
> >
> > thanks,
> >
> > greg k-h
> 
> Hmmm ... this function is rarely used, and maybe over-designed. The
> 'prefix' feature can be actually removed -- nobody uses it.

Then just remove it :)

thanks,

greg k-h

      reply	other threads:[~2012-10-26 18:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26 17:55 [PATCH 1/3] debugfs: pass NULL as the last parameter of debugfs_print_regs32() Yan Hong
2012-10-26 17:55 ` [PATCH 2/3] debugfs: code clean and refactor Yan Hong
2012-10-26 18:12   ` Greg KH
2012-10-26 17:55 ` [PATCH 3/3] debugfs: break long lines Yan Hong
2012-10-26 18:12   ` Greg KH
2012-10-26 18:13 ` [PATCH 1/3] debugfs: pass NULL as the last parameter of debugfs_print_regs32() Greg KH
2012-10-26 18:34   ` yan yan
2012-10-26 18:48     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121026184833.GA17121@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=clouds.yan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).