Re: [PATCH 31/33] perf, tools: Support generic events as pmu event names v2

Andi Kleen
2012-10-28T19:12:46Z

On Sat, Oct 27, 2012 at 09:42:00PM +0200, Jiri Olsa wrote:
> On Fri, Oct 26, 2012 at 01:30:13PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > Extend the parser/lexer to allow generic event names like
> > "instructions" as a sysfs supplied PMU event name.
> >
> > This resolves the problem that cpu/instructions/ gives a parse
> > error, even when the kernel supplies a "instructions" event
> >
> > This is useful to add sysfs specified qualifiers to these
> > events, for example cpu/instructions,intx=1/ and needed
> > for the TSX events
> >
> > Simply extend the grammar to handle this case. The lexer
> > needs minor changes to save the original string.
>
> ops, I think you need to check recent changes:

Note I wrote and posted all this before you posted last week, but the wheels
of perf review grind so slowly that you overtook me.

Peter Z., to be honest all these later patches are just caused by not having
generic TSX events/modifiers and you not liking my original approach.

I'm now at 10+ patches for the sysfs stuff and counting and have conflicts
with parallel work by Jiri and in general it's still all somewhat hacky and
actually far more code than the original patches.

I'm very tempted to go back to the original approach with generic
events and modifiers, that was far simpler and cleaner and really
did work better, and it was a far less intrusive patchkit.

Comments?

-Andi